Skip to content

Commit

Permalink
apacheGH-34271: [C++] Remove Thrift GitHub archive source url (apache…
Browse files Browse the repository at this point in the history
…#34273)

Thirft's [GitHub release files](https://github.com/apache/thrift/releases) do not match the checksum of official source files.

> The assets listed below are added by Github based on the release tag and they will therefore not match the checkums published on the Thrift project website.

Using it as Thrift_SOURCE_URL causes issues such as apache#34271.
* Closes: apache#34271

Authored-by: Jin Shang <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
js8544 authored Feb 21, 2023
1 parent 7828165 commit ac8e093
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cpp/cmake_modules/ThirdpartyToolchain.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,6 @@ else()
set_urls(THRIFT_SOURCE_URL
"https://www.apache.org/dyn/closer.cgi?action=download&filename=/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
"https://downloads.apache.org/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
"https://github.com/apache/thrift/archive/v${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
"https://apache.claz.org/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
"https://apache.cs.utah.edu/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
"https://apache.mirrors.lucidnetworks.net/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
Expand Down

0 comments on commit ac8e093

Please sign in to comment.