Skip to content

Commit

Permalink
Merge pull request DefinitelyTyped#17913 from JimiC/mssql_types_improve
Browse files Browse the repository at this point in the history
[mssql] Inherit from Array for columns and rows.
  • Loading branch information
RyanCavanaugh authored Jul 14, 2017
2 parents 3f9f7b8 + cf90dee commit 0fe2e61
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions types/mssql/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Type definitions for mssql 4.0.4
// Type definitions for mssql 4.0.5
// Project: https://www.npmjs.com/package/mssql
// Definitions by: COLSA Corporation <http://www.colsa.com/>, Ben Farr <https://github.com/jaminfarr>, Vitor Buzinaro <https://github.com/buzinas>, Matt Richardson <https://github.com/mrrichar/>, Jørgen Elgaard Larsen <https://github.com/elhaard/>, Peter Keuter <https://github.com/pkeuter/>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
Expand Down Expand Up @@ -214,13 +214,13 @@ export interface IColumn extends ISqlType {
primary: boolean;
}

declare class columns {
declare class columns extends Array {
public add(name: string, type: (() => ISqlType) | ISqlType, options?: IColumnOptions): number;
}

type IRow = (string | number | boolean | Date | Buffer)[];
type IRow = (string | number | boolean | Date | Buffer | undefined)[];

declare class rows {
declare class rows extends Array {
public add(...row: IRow): number;
}

Expand Down

0 comments on commit 0fe2e61

Please sign in to comment.