for example specification 1,000 MB to 1000 MB , No comma separated he…

…re (linkedin#396) * for specification 1,000 MB to 1000 MB java.lang.IllegalArgumentException: The formatted string [1,000 MB] does not match with the regex * add the unit test case to test ignore thousand-separator(1,000 MB to 1000 MB) in MemoryFormatUtilsTest
jeesim2 · Sep 16, 2019 · 721c82a · 721c82a
1 parent 2c79e8c
commit 721c82a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/app/com/linkedin/drelephant/util/MemoryFormatUtils.java b/app/com/linkedin/drelephant/util/MemoryFormatUtils.java
@@ -94,7 +94,7 @@ public static long stringToBytes(String formattedString) {
       return 0L;
     }
 
-    Matcher matcher = REGEX_MATCHER.matcher(formattedString);
+    Matcher matcher = REGEX_MATCHER.matcher(formattedString.replace(",",""));
     if (!matcher.matches()) {
       throw new IllegalArgumentException(
           "The formatted string [" + formattedString + "] does not match with the regex /" + REGEX_MATCHER.toString()

diff --git a/test/com/linkedin/drelephant/util/MemoryFormatUtilsTest.java b/test/com/linkedin/drelephant/util/MemoryFormatUtilsTest.java
@@ -50,6 +50,8 @@ public void testScientificStringNumberToBytes() {
     assertEquals(expectedBytes, MemoryFormatUtils.stringToBytes("0.879e1 MB"));
     assertEquals(expectedBytes, MemoryFormatUtils.stringToBytes("+0.879e+1 MB"));
     assertEquals(expectedBytes, MemoryFormatUtils.stringToBytes("87.9e-1 MB"));
+    assertEquals(expectedBytes, MemoryFormatUtils.stringToBytes("8,790e-3 MB"));
+    assertEquals(expectedBytes, MemoryFormatUtils.stringToBytes("8,790,000e-6 MB"));
   }
 
   public void testStringToBytes() {