Skip to content

Commit

Permalink
Rename loggerList to logWriterList in LoggerConfig (touchlab#135)
Browse files Browse the repository at this point in the history
  • Loading branch information
findjigar authored Sep 10, 2021
1 parent faf3d00 commit 314e41d
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class LogcatLoggerTest {

private val testConfig = TestConfig(
minSeverity = Severity.Verbose,
loggerList = listOf(LogcatWriter()),
logWriterList = listOf(LogcatWriter()),
defaultTag = DEFAULT_TAG
)

Expand Down
8 changes: 4 additions & 4 deletions kermit/src/commonMain/kotlin/co/touchlab/kermit/Logger.kt
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ open class Logger(
message: String,
loggingCall: LogWriter.(message: String, tag: String, throwable: Throwable?) -> Unit
) {
config.loggerList.forEach {
config.logWriterList.forEach {
if (it.isLoggable(severity)) {
it.loggingCall(message, tag, throwable)
}
Expand All @@ -153,15 +153,15 @@ open class Logger(
}

fun setLogWriters(logWriters: List<LogWriter>) {
LoggerGlobal.defaultConfig.loggerList = logWriters
LoggerGlobal.defaultConfig.logWriterList = logWriters
}

fun setLogWriters(vararg logWriter: LogWriter) {
LoggerGlobal.defaultConfig.loggerList = logWriter.toList()
LoggerGlobal.defaultConfig.logWriterList = logWriter.toList()
}

fun addLogWriter(vararg logWriter: LogWriter) {
LoggerGlobal.defaultConfig.loggerList = logWriter.toList() + LoggerGlobal.defaultConfig.loggerList
LoggerGlobal.defaultConfig.logWriterList = logWriter.toList() + LoggerGlobal.defaultConfig.logWriterList
}

fun setDefaultTag(tag: String) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ package co.touchlab.kermit

interface LoggerConfig {
val minSeverity:Severity
val loggerList: List<LogWriter>
val logWriterList: List<LogWriter>
val defaultTag: String
companion object {
@Suppress("unused")
Expand All @@ -25,6 +25,6 @@ interface LoggerConfig {

data class StaticConfig(
override val minSeverity: Severity = DEFAULT_MIN_SEVERITY,
override val loggerList: List<LogWriter> = listOf(CommonWriter()),
override val logWriterList: List<LogWriter> = listOf(CommonWriter()),
override val defaultTag: String = "Kermit"
): LoggerConfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ package co.touchlab.kermit

interface MutableLoggerConfig : LoggerConfig {
override var minSeverity: Severity
override var loggerList: List<LogWriter>
override var logWriterList: List<LogWriter>
override var defaultTag: String
}
10 changes: 5 additions & 5 deletions kermit/src/commonTest/kotlin/co/touchlab/kermit/KermitTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ class KermitTest {
private val testLogWriter = TestLogWriter(loggable = Severity.Verbose)
private val testConfig = TestConfig(
minSeverity = Severity.Verbose,
loggerList = listOf(testLogWriter),
logWriterList = listOf(testLogWriter),
defaultTag = "Kermit"
)

@Test
fun defaultConfigTest() {
val logger = Logger(LoggerConfig.default.copy(loggerList = listOf(testLogWriter)))
val logger = Logger(LoggerConfig.default.copy(logWriterList = listOf(testLogWriter)))
logger.v { "Message" }
testLogWriter.assertCount(1)
}
Expand Down Expand Up @@ -59,7 +59,7 @@ class KermitTest {
@Test
fun testIsLoggable() {
val errorLogWriter = TestLogWriter(Severity.Error)
val logger = Logger(testConfig.copy(loggerList = listOf(errorLogWriter)))
val logger = Logger(testConfig.copy(logWriterList = listOf(errorLogWriter)))

logger.v { "verbose" }
logger.d { "debug" }
Expand All @@ -78,8 +78,8 @@ class KermitTest {
@Test
fun testMultipleLoggers() {
val secondaryLogWriter = TestLogWriter(loggable = Severity.Verbose)
val loggerList = listOf(testLogWriter, secondaryLogWriter)
val logger = Logger(testConfig.copy(loggerList = loggerList))
val logWriterList = listOf(testLogWriter, secondaryLogWriter)
val logger = Logger(testConfig.copy(logWriterList = logWriterList))
logger.e { "Message" }

testLogWriter.assertLast { message == "Message" }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import kotlin.test.assertTrue

data class TestConfig(
override val minSeverity: Severity,
override val loggerList: List<LogWriter>,
override val logWriterList: List<LogWriter>,
override val defaultTag: String
) : LoggerConfig

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ package co.touchlab.kermit

internal class JsMutableLoggerConfig : MutableLoggerConfig {
override var minSeverity: Severity = DEFAULT_MIN_SEVERITY
override var loggerList: List<LogWriter> = listOf(
override var logWriterList: List<LogWriter> = listOf(
CommonWriter()
)
override var defaultTag: String = "Kermit"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ internal class JvmMutableLoggerConfig : MutableLoggerConfig {
}
}

override var loggerList: List<LogWriter>
override var logWriterList: List<LogWriter>
get() = _loggerList
set(value) {
synchronized(this) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ internal class AtomicMutableLoggerConfig : MutableLoggerConfig {
set(value) {
_minSeverity.value = value
}
override var loggerList: List<LogWriter>
override var logWriterList: List<LogWriter>
get() = _loggerList.value
set(value) {
_loggerList.value = value.freeze()
Expand Down

0 comments on commit 314e41d

Please sign in to comment.