Skip to content

Commit

Permalink
feat(Chromium): roll Chromium to r549031 (puppeteer#2327)
Browse files Browse the repository at this point in the history
This roll includes:
- https://crrev.com/549003 - DevTools: make pptr tests pass with DCHECKs.

The patch fixes a browser crash that happens during browser close.
As a result, cookies were not saved properly (and thus the flaky test we
had).

Fixes puppeteer#1537.
  • Loading branch information
aslushnikov authored Apr 7, 2018
1 parent 8c54f41 commit 45d97e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"ws": "^3.0.0"
},
"puppeteer": {
"chromium_revision": "548921"
"chromium_revision": "549031"
},
"devDependencies": {
"@types/debug": "0.0.30",
Expand Down
3 changes: 1 addition & 2 deletions test/puppeteer.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
await browser2.close();
rm(userDataDir);
});
// @see https://github.com/GoogleChrome/puppeteer/issues/1537
xit('userDataDir option should restore cookies', async({server}) => {
it('userDataDir option should restore cookies', async({server}) => {
const userDataDir = await mkdtempAsync(TMP_FOLDER);
const options = Object.assign({userDataDir}, defaultBrowserOptions);
const browser = await puppeteer.launch(options);
Expand Down

0 comments on commit 45d97e5

Please sign in to comment.