IQSS#4139 Allow "update dataset" perms to download files of in review…

… datasets.
jeffreychung · Nov 2, 2017 · 2442b3f · 2442b3f
1 parent 08fd6f6
commit 2442b3f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/PermissionServiceBean.java b/src/main/java/edu/harvard/iq/dataverse/PermissionServiceBean.java
@@ -29,6 +29,7 @@
 import edu.harvard.iq.dataverse.engine.command.exception.IllegalCommandException;
 import edu.harvard.iq.dataverse.engine.command.impl.CreateDatasetCommand;
 import edu.harvard.iq.dataverse.engine.command.impl.PublishDatasetCommand;
+import edu.harvard.iq.dataverse.engine.command.impl.UpdateDatasetCommand;
 import edu.harvard.iq.dataverse.util.BundleUtil;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -568,8 +569,8 @@ public void checkEditDatasetLock(Dataset dataset, DataverseRequest dataverseRequ
     public void checkDownloadFileLock(Dataset dataset, DataverseRequest dataverseRequest, Command command) throws IllegalCommandException {
         if (dataset.isLocked()) {
             if (dataset.isLockedFor(DatasetLock.Reason.InReview)) {
-                // The "InReview" lock is not really a lock for curators or contributors. They can still download.
-                if (!isUserAllowedOn(dataverseRequest.getUser(), new CreateDatasetCommand(dataset, dataverseRequest, true), dataset)) {
+                // The "InReview" lock is not really a lock for curators or contributors. They can still download.                
+                if (!isUserAllowedOn(dataverseRequest.getUser(), new UpdateDatasetCommand(dataset, dataverseRequest), dataset)) {
                     throw new IllegalCommandException(BundleUtil.getStringFromBundle("dataset.message.locked.downloadNotAllowedInReview"), command);
                 }
             }