Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused fonts #93

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Remove unused fonts #93

merged 2 commits into from
Oct 10, 2021

Conversation

dmitrylyzo
Copy link
Collaborator

@dmitrylyzo dmitrylyzo commented Oct 10, 2021 •
edited
Loading

This will reduce the size of the WGT.

Changes
Remove Noto Sans fonts from www because they are not used on TV: https://github.com/jellyfin/jellyfin-web/blob/4121ca493a6d274302543d04c75d555f6aac9117/src/scripts/site.js#L118-L124

Issues
Fixes #12

oddstr13
oddstr13 approved these changes Oct 10, 2021
View reviewed changes
Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the details of how the web packaging works, but this looks fine to me

@dmitrylyzo
Copy link
Collaborator Author

I tested how it would work if fonts.scss gets into the main bundle (also in development mode - with comments) - not good 😅
So I added a check for the file existence.

It was approved while I was writing 😄

@dmitrylyzo dmitrylyzo merged commit 37f723f into master Oct 10, 2021
@dmitrylyzo dmitrylyzo deleted the remove-unused-fonts branch October 10, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddstr13 oddstr13 oddstr13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Are all 31.1 MiB of fonts actually needed?
2 participants
@dmitrylyzo @oddstr13