Skip to content

Commit

Permalink
Clarify deprecation and error messages
Browse files Browse the repository at this point in the history
Refer to the actual text box names/titles in the messages.
  • Loading branch information
alexh-sauce committed Jan 15, 2025
1 parent be523b2 commit 9fc7c48
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
// Validation logic: Fail if both fields are set
if (optionsValue && sauceConnectCLIOptionsValue) {
isValid = false;
message = '"Sauce Connect Legacy Options" and "Sauce Connect Options" cannot both be set. Please use SC5 style CLI flags only.';
message = '"Sauce Connect Legacy v4 Options" and "Sauce Connect v5 Options" cannot both be set. Please use "Sauce Connect v5 Options" only.';
}

// Update UI
Expand All @@ -56,7 +56,7 @@

if (optionsValue) {
isDeprecated = true;
deprecationText = "Legacy SC4 CLI commands are deprecated. Please update to SC5 style CLI flags."
deprecationText = '"Sauce Connect Legacy v4 Options" is deprecated. Please use "Sauce Connect v5 Options".'
}
deprecationMessage.textContent = deprecationText;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
// Validation logic: Fail if both fields are set
if (optionsValue && cliOptionsValue) {
isValid = false;
message = '"Sauce Connect Legacy v4 Options" and "Sauce Connect v5 Options" cannot both be set. Please use SC5 style CLI flags only.';
message = '"Sauce Connect Legacy v4 Options" and "Sauce Connect v5 Options" cannot both be set. Please use "Sauce Connect v5 Options" only.';
}

// Update UI
Expand All @@ -129,7 +129,7 @@

if (optionsValue) {
isDeprecated = true;
deprecationText = "Legacy SC4 CLI commands are deprecated. Please update to SC5 style CLI flags."
deprecationText = '"Sauce Connect Legacy v4 Options" is deprecated. Please use "Sauce Connect v5 Options".'
}
deprecationMessage.textContent = deprecationText;
}
Expand Down

0 comments on commit 9fc7c48

Please sign in to comment.