Update composer.json

[tarampampam]

Package nikic/php-parser minimal version is ^2.0 (otherwise - tests failed)

[GrahamCampbell]

Thanks for the PR. I think we need to instead work out why the tests fail, and restore compatibility though?

[tarampampam]

Just try it by yourself:

$ cd ~/tmp
$ git clone [email protected]:jeremeamia/super_closure.git
$ cd super_closure
$ composer update
$ ./vendor/bin/phpunit
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

..................................................                50 / 50 (100%)

Time: 491 ms, Memory: 18.00MB

OK (50 tests, 115 assertions)
$ composer update --no-interaction --prefer-lowest
$ ./vendor/bin/phpunit
PHPUnit 2.4.0 by Sebastian Bergmann.

Configuration read from /home/kot/tmp/super_closure/phpunit.xml.dist

PHP Fatal error:  Declaration of PHPUnit_Framework_Comparator_DOMNode::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with PHPUnit_Framework_Comparator_Object::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in /home/user/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/Comparator/DOMNode.php on line 136
PHP Stack trace:
PHP   1. {main}() /home/user/tmp/super_closure/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/phpunit:55
PHP   3. PHPUnit_TextUI_Command->run() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/TextUI/Command.php:132
PHP   4. PHPUnit_TextUI_TestRunner->doRun() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/TextUI/Command.php:179
PHP   5. PHPUnit_Framework_TestSuite->run() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:419
PHP   6. PHPUnit_Framework_TestSuite->run() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
PHP   7. PHPUnit_Framework_TestSuite->run() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
PHP   8. SuperClosure\Test\Unit\Analyzer\TokenTest->run() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
PHP   9. PHPUnit_Framework_TestResult->run() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestCase.php:764
PHP  10. SuperClosure\Test\Unit\Analyzer\TokenTest->runBare() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestResult.php:692
PHP  11. SuperClosure\Test\Unit\Analyzer\TokenTest->runTest() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestCase.php:824
PHP  12. ReflectionMethod->invokeArgs() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestCase.php:955
PHP  13. SuperClosure\Test\Unit\Analyzer\TokenTest->testCanInstantiateLiteralToken() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/TestCase.php:955
PHP  14. PHPUnit_Framework_Assert::assertEquals() /home/kot/tmp/super_closure/tests/Unit/Analyzer/TokenTest.php:14
PHP  15. PHPUnit_Framework_Assert::assertThat() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/Assert.php:475
PHP  16. PHPUnit_Framework_Constraint_IsEqual->evaluate() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/Assert.php:2166
PHP  17. PHPUnit_Framework_ComparatorFactory::getDefaultInstance() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/Constraint/IsEqual.php:152
PHP  18. PHPUnit_Framework_ComparatorFactory->__construct() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/ComparatorFactory.php:96
PHP  19. spl_autoload_call() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/ComparatorFactory.php:83
PHP  20. Composer\Autoload\ClassLoader->loadClass() /home/kot/tmp/super_closure/vendor/phpunit/phpunit/src/Framework/ComparatorFactory.php:83
PHP  21. Composer\Autoload\includeFile() /home/kot/tmp/super_closure/vendor/composer/ClassLoader.php:322

So, as minimal - minimum phpunit version needs to be upped.

[GrahamCampbell]

Our travis tests already show that we support php-parser 1.x: https://github.com/jeremeamia/super_closure/blob/master/.travis.yml. Which version combinations cause things to break please?

[GrahamCampbell]

I'm confused as to how phpunit 2.x was installed when we specify 4.x as the minimum.

[jeremeamia]

This software is no longer maintained. Consider using opis/closure instead.