🐍 Pythonic use of or

jeremy-duckworth · Mar 30, 2020 · 6ec6f43 · 6ec6f43
1 parent 7c32918
commit 6ec6f43
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/detect_secrets/core/log.py b/detect_secrets/core/log.py
@@ -7,7 +7,7 @@ def get_logger(name=None, format_string=None):
     :type name: str
     :param name: used for declaring log channels.
 
-    :type format_string: str
+    :type format_string: str|None
     :param format_string: for custom formatting
     """
     logging.captureWarnings(True)
@@ -18,14 +18,15 @@ def get_logger(name=None, format_string=None):
     log.set_debug_level = _set_debug_level.__get__(log)
     log.set_debug_level(0)
 
-    if not format_string:
-        format_string = '[%(module)s]\t%(levelname)s\t%(message)s'
-
     # Setting up log formats
     log.handlers = []
     handler = logging.StreamHandler(sys.stderr)
     handler.setFormatter(
-        logging.Formatter(format_string),
+        logging.Formatter(
+            format_string
+            or
+            '[%(module)s]\t%(levelname)s\t%(message)s',
+        ),
     )
     log.addHandler(handler)
 

diff --git a/detect_secrets/core/usage.py b/detect_secrets/core/usage.py
@@ -281,12 +281,9 @@ class PluginDescriptor(
     ),
 ):
     def __new__(cls, related_args=None, **kwargs):
-        if not related_args:
-            related_args = []
-
         return super(PluginDescriptor, cls).__new__(
             cls,
-            related_args=related_args,
+            related_args=related_args or [],
             **kwargs
         )