do not close over variables in a function

jermainlaforce · Feb 25, 2020 · 8eb0b0f · 8eb0b0f
1 parent e6a8dc0
commit 8eb0b0f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/gui/rebase_options_panel.go b/pkg/gui/rebase_options_panel.go
@@ -16,10 +16,12 @@ func (gui *Gui) handleCreateRebaseOptionsMenu(g *gocui.Gui, v *gocui.View) error
 
 	menuItems := make([]*menuItem, len(options))
 	for i, option := range options {
+		// note to self. Never, EVER, close over loop variables in a function
+		innerOption := option
 		menuItems[i] = &menuItem{
-			displayString: option,
+			displayString: innerOption,
 			onPress: func() error {
-				return gui.genericMergeCommand(option)
+				return gui.genericMergeCommand(innerOption)
 			},
 		}
 	}