Skip to content

Commit

Permalink
trace-cmd report: Init the top trace instance earlier
Browse files Browse the repository at this point in the history
Moved initialization of the instance before call to the tracecmd_cpus()
API. This change is required for the upcoming trace file changes, where
CPU count is set when the trace data are initialized.

Link: https://lore.kernel.org/linux-trace-devel/[email protected]

Signed-off-by: Tzvetomir Stoyanov (VMware) <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
  • Loading branch information
tzstoyanov authored and rostedt committed Oct 5, 2021
1 parent 0b98cc5 commit 18147cc
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tracecmd/trace-read.c
Original file line number Diff line number Diff line change
Expand Up @@ -1215,6 +1215,11 @@ static void read_data_info(struct list_head *handle_list, enum output_type otype
list_for_each_entry(handles, handle_list, list) {
int cpus;

if (!tracecmd_is_buffer_instance(handles->handle)) {
ret = tracecmd_init_data(handles->handle);
if (ret < 0)
die("failed to init data");
}
cpus = tracecmd_cpus(handles->handle);
handles->cpus = cpus;
handles->last_timestamp = calloc(cpus, sizeof(*handles->last_timestamp));
Expand All @@ -1225,9 +1230,6 @@ static void read_data_info(struct list_head *handle_list, enum output_type otype
if (tracecmd_is_buffer_instance(handles->handle))
continue;

ret = tracecmd_init_data(handles->handle);
if (ret < 0)
die("failed to init data");
if (align_ts) {
ts = tracecmd_get_first_ts(handles->handle);
if (first || first_ts > ts)
Expand Down

0 comments on commit 18147cc

Please sign in to comment.