Skip to content

Commit

Permalink
net: hdlc_ppp: remove unnecessary out of memory message
Browse files Browse the repository at this point in the history
This patch removes unnecessary out of memory message,
to fix the following checkpatch.pl warning:
"WARNING: Possible unnecessary 'out of memory' message"

Signed-off-by: Peng Li <[email protected]>
Signed-off-by: Guangbin Huang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
321lipeng authored and davem330 committed Jun 17, 2021
1 parent 4ec4795 commit ee58a3c
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/wan/hdlc_ppp.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,9 @@ static void ppp_tx_cp(struct net_device *dev, u16 pid, u8 code,

skb = dev_alloc_skb(sizeof(struct hdlc_header) +
sizeof(struct cp_header) + magic_len + len);
if (!skb) {
netdev_warn(dev, "out of memory in ppp_tx_cp()\n");
if (!skb)
return;
}

skb_reserve(skb, sizeof(struct hdlc_header));

cp = skb_put(skb, sizeof(struct cp_header));
Expand Down

0 comments on commit ee58a3c

Please sign in to comment.