Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes across several files, focusing on adding new features, refactoring code, and updating dependencies. The most important changes are grouped into themes: feature additions, internal refactoring, and dependency updates.
Feature Additions:
glob
keyword argument towalkdir
to filter the walk based onry.Glob
,ry.GlobSet
, orry.Globster
objects. (CHANGELOG.md
,crates/ryo3-walkdir/src/lib.rs
) [1] [2] [3] [4] [5] [6] [7]Internal Refactoring:
PyGlob
,PyGlobSet
, andGlobster
structs to include new methodsglobster()
andglobset()
, and made them public. (crates/ryo3-globset/src/lib.rs
) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]impl PyGlobPatterns for PyGlobSet
to usePyGlobster
. (crates/ryo3-globset/src/lib.rs
)PyFsPath
to usestd::fs::write
forwrite_text
method and refactorediterdir
to usePyReadDir
. (crates/ryo3/src/fs/fspath.rs
) [1] [2]Dependency Updates:
ryo3-globset.workspace = true
inCargo.toml
files to ensure the workspace is correctly set up. (crates/ryo3-globset/Cargo.toml
,crates/ryo3-walkdir/Cargo.toml
) [1] [2]clippy::too_many_arguments
lint allowance fromryo3-walkdir/src/lib.rs
. (crates/ryo3-walkdir/src/lib.rs
)These changes collectively enhance the functionality and maintainability of the codebase.