Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkdir glob #141

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Walkdir glob #141

merged 8 commits into from
Dec 11, 2024

Conversation

jessekrubin
Copy link
Owner

@jessekrubin jessekrubin commented Dec 11, 2024

This pull request includes multiple changes across several files, focusing on adding new features, refactoring code, and updating dependencies. The most important changes are grouped into themes: feature additions, internal refactoring, and dependency updates.

Feature Additions:

  • Added glob keyword argument to walkdir to filter the walk based on ry.Glob, ry.GlobSet, or ry.Globster objects. (CHANGELOG.md, crates/ryo3-walkdir/src/lib.rs) [1] [2] [3] [4] [5] [6] [7]

Internal Refactoring:

  • Refactored PyGlob, PyGlobSet, and Globster structs to include new methods globster() and globset(), and made them public. (crates/ryo3-globset/src/lib.rs) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Updated impl PyGlobPatterns for PyGlobSet to use PyGlobster. (crates/ryo3-globset/src/lib.rs)
  • Modified PyFsPath to use std::fs::write for write_text method and refactored iterdir to use PyReadDir. (crates/ryo3/src/fs/fspath.rs) [1] [2]

Dependency Updates:

  • Added ryo3-globset.workspace = true in Cargo.toml files to ensure the workspace is correctly set up. (crates/ryo3-globset/Cargo.toml, crates/ryo3-walkdir/Cargo.toml) [1] [2]
  • Removed clippy::too_many_arguments lint allowance from ryo3-walkdir/src/lib.rs. (crates/ryo3-walkdir/src/lib.rs)

These changes collectively enhance the functionality and maintainability of the codebase.

@jessekrubin jessekrubin merged commit 04e67d9 into main Dec 11, 2024
22 checks passed
@jessekrubin jessekrubin deleted the walkdir-glob branch December 11, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant