Consider Pointers with Attached Type Information as Safe to Dereference

jessestuart · Mar 29, 2019 · 532fc14 · 532fc14
1 parent e53493e
commit 532fc14
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...ffle.llvm.nodes/src/com/oracle/truffle/llvm/nodes/intrinsics/llvm/debug/LLDBConstant.java b/...ffle.llvm.nodes/src/com/oracle/truffle/llvm/nodes/intrinsics/llvm/debug/LLDBConstant.java
@@ -347,7 +347,7 @@ public boolean isAlwaysSafeToDereference(long bitOffset) {
                 return LLVMManagedPointer.isInstance(target);
             }
 
-            return false;
+            return bitOffset == 0L && pointer.getExportType() != null;
         }
 
         @Override

diff --git a/...e.llvm.nodes/src/com/oracle/truffle/llvm/nodes/intrinsics/llvm/debug/LLDBMemoryValue.java b/...e.llvm.nodes/src/com/oracle/truffle/llvm/nodes/intrinsics/llvm/debug/LLDBMemoryValue.java
@@ -382,7 +382,9 @@ public boolean isAlwaysSafeToDereference(long bitOffset) {
         if (LLVMManagedPointer.isInstance(pointerRead)) {
             return LLDBSupport.pointsToObjectAccess(LLVMManagedPointer.cast(pointerRead));
         }
-        return false;
+
+        return LLVMPointer.isInstance(pointerRead) && LLVMPointer.cast(pointerRead).getExportType() != null;
+
     }
 
     @Override