Skip to content

Commit

Permalink
Scoring loopback addresses as 0 in DefaultChannelId
Browse files Browse the repository at this point in the history
Motivation:

As described in netty#3490, [compareAddresses](https://github.com/netty/netty/blob/master/transport/src/main/java/io/netty/channel/DefaultChannelId.java#L182)  seems to allow loopback addresses to score high, disallowing replacing the loopback address.

Modifications:

Changed [scoreAddress](https://github.com/netty/netty/blob/master/transport/src/main/java/io/netty/channel/DefaultChannelId.java#L283) to score loopback addresses as 0.

Result:

Fixes netty#3490
  • Loading branch information
nmittler committed May 8, 2015
1 parent c88de88 commit dca6cea
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ private static int compareAddresses(InetAddress current, InetAddress candidate)
}

private static int scoreAddress(InetAddress addr) {
if (addr.isAnyLocalAddress()) {
if (addr.isAnyLocalAddress() || addr.isLoopbackAddress()) {
return 0;
}
if (addr.isMulticastAddress()) {
Expand Down

0 comments on commit dca6cea

Please sign in to comment.