fix: types for sheet nav

jesulim · Sep 16, 2023 · d95a018 · d95a018
1 parent 321b7a7
commit d95a018
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/src/components/layout/sheet-mobile-nav.tsx b/src/components/layout/sheet-mobile-nav.tsx
@@ -80,6 +80,7 @@ export function SheetMobileNav() {
                         {subItem.href ? (
                           <a
                             href={subItem.href}
+                            target={subItem?.external ? "_blank" : undefined}
                             className="text-muted-foreground"
                           >
                             {subItem.title}

diff --git a/src/components/main-navigation-menu.tsx b/src/components/main-navigation-menu.tsx
@@ -12,15 +12,7 @@ import {
 } from "@/components/ui/navigation-menu";
 import { Badge } from "@/components/ui/badge";
 import { navMenuConfig } from "@/config/nav-menu";
-
-type MenuItem = {
-  title: string;
-  href: string;
-  description: string;
-  launched?: boolean;
-  disabled?: boolean;
-  external?: boolean;
-};
+import type { MenuItem } from "@/types";
 
 const infos = navMenuConfig.infosNav[0];
 const examples = navMenuConfig.examplesNav[0];

diff --git a/src/types/index.d.ts b/src/types/index.d.ts
@@ -6,7 +6,7 @@ export type NavItem = {
   disabled?: boolean;
 };
 export type MenuItem = NavItem & {
-  description: string;
+  description?: string;
   launched?: boolean;
   external?: boolean;
 };
@@ -24,7 +24,7 @@ export type SidebarNavItem = {
     }
   | {
       href?: string;
-      items: NavLink[];
+      items: MenuItem[];
     }
 );