[cmake] BUILD_DEP_TARGET move include and add docinfo

jfly · Mar 7, 2022 · 419dc83 · 419dc83
1 parent a4ed6ec
commit 419dc83
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 8 deletions.
diff --git a/cmake/modules/FindCrossGUID.cmake b/cmake/modules/FindCrossGUID.cmake
@@ -1,5 +1,4 @@
 if(ENABLE_INTERNAL_CROSSGUID)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC crossguid)

diff --git a/cmake/modules/FindDav1d.cmake b/cmake/modules/FindDav1d.cmake
@@ -10,7 +10,6 @@
 # DAV1D_LIBRARIES - the dav1d libraries
 
 if(ENABLE_INTERNAL_DAV1D)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC dav1d)

diff --git a/cmake/modules/FindFlatBuffers.cmake b/cmake/modules/FindFlatBuffers.cmake
@@ -10,7 +10,6 @@
 # FLATBUFFERS_MESSAGES_INCLUDE_DIR - the directory for generated headers
 
 if(ENABLE_INTERNAL_FLATBUFFERS)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC flatbuffers)

diff --git a/cmake/modules/FindFmt.cmake b/cmake/modules/FindFmt.cmake
@@ -13,7 +13,6 @@
 #   fmt   - The Fmt library
 
 if(ENABLE_INTERNAL_FMT)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC fmt)

diff --git a/cmake/modules/FindFstrcmp.cmake b/cmake/modules/FindFstrcmp.cmake
@@ -12,7 +12,6 @@
 
 if(ENABLE_INTERNAL_FSTRCMP)
   find_program(LIBTOOL libtool REQUIRED)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC fstrcmp)

diff --git a/cmake/modules/FindRapidJSON.cmake b/cmake/modules/FindRapidJSON.cmake
@@ -9,7 +9,6 @@
 # RapidJSON_INCLUDE_DIRS - the RapidJSON parser include directory
 #
 if(ENABLE_INTERNAL_RapidJSON)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC rapidjson)

diff --git a/cmake/modules/FindSpdlog.cmake b/cmake/modules/FindSpdlog.cmake
@@ -14,7 +14,6 @@
 #   Spdlog::Spdlog   - The Spdlog library
 
 if(ENABLE_INTERNAL_SPDLOG)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC spdlog)

diff --git a/cmake/modules/FindUdfread.cmake b/cmake/modules/FindUdfread.cmake
@@ -11,7 +11,6 @@
 # UDFREAD_DEFINITIONS - the udfread definitions
 
 if(ENABLE_INTERNAL_UDFREAD)
-  include(ExternalProject)
   include(cmake/scripts/common/ModuleHelpers.cmake)
 
   set(MODULE_LC udfread)

diff --git a/cmake/scripts/common/ModuleHelpers.cmake b/cmake/scripts/common/ModuleHelpers.cmake
@@ -86,7 +86,20 @@ macro(SETUP_BUILD_VARS)
 endmacro()
 
 # Macro to create externalproject_add target
+# 
+# Common usage
+#
+# CMAKE_ARGS: cmake(required)
+# PATCH_COMMAND: ALL(optional)
+# CONFIGURE_COMMAND: autoconf(required), meson(required)
+# BUILD_COMMAND: autoconf(required), meson(required), cmake(optional)
+# INSTALL_COMMAND: autoconf(required), meson(required), cmake(optional)
+# BUILD_IN_SOURCE: ALL(optional)
+# BUILD_BYPRODUCTS: ALL(optional)
+#
 macro(BUILD_DEP_TARGET)
+  include(ExternalProject)
+
   if(CMAKE_ARGS)
     set(CMAKE_ARGS CMAKE_ARGS ${CMAKE_ARGS})
   endif()