Skip to content

Commit

Permalink
unicode: Rename is_XID_start to is_xid_start, is_XID_continue to is_x…
Browse files Browse the repository at this point in the history
…id_continue
  • Loading branch information
brson committed Nov 21, 2014
1 parent 76ddd2b commit f39c29d
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/libfmt_macros/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ impl<'a> Parser<'a> {
/// characters.
fn word(&mut self) -> &'a str {
let start = match self.cur.clone().next() {
Some((pos, c)) if c.is_XID_start() => {
Some((pos, c)) if c.is_xid_start() => {
self.cur.next();
pos
}
Expand All @@ -392,7 +392,7 @@ impl<'a> Parser<'a> {
let mut end;
loop {
match self.cur.clone().next() {
Some((_, c)) if c.is_XID_continue() => {
Some((_, c)) if c.is_xid_continue() => {
self.cur.next();
}
Some((pos, _)) => { end = pos; break }
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_trans/back/link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ pub fn sanitize(s: &str) -> String {
// Underscore-qualify anything that didn't start as an ident.
if result.len() > 0u &&
result.as_bytes()[0] != '_' as u8 &&
! (result.as_bytes()[0] as char).is_XID_start() {
! (result.as_bytes()[0] as char).is_xid_start() {
return format!("_{}", result.as_slice());
}

Expand Down
4 changes: 2 additions & 2 deletions src/librustdoc/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ impl Collector {
// we use these headings as test names, so it's good if
// they're valid identifiers.
let name = name.chars().enumerate().map(|(i, c)| {
if (i == 0 && c.is_XID_start()) ||
(i != 0 && c.is_XID_continue()) {
if (i == 0 && c.is_xid_start()) ||
(i != 0 && c.is_xid_continue()) {
c
} else {
'_'
Expand Down
6 changes: 3 additions & 3 deletions src/libsyntax/parse/lexer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ impl<'a> StringReader<'a> {
// integer literal followed by field/method access or a range pattern
// (`0..2` and `12.foo()`)
if self.curr_is('.') && !self.nextch_is('.') && !self.nextch().unwrap_or('\0')
.is_XID_start() {
.is_xid_start() {
// might have stuff after the ., and if it does, it needs to start
// with a number
self.bump();
Expand Down Expand Up @@ -1385,7 +1385,7 @@ fn ident_start(c: Option<char>) -> bool {
(c >= 'a' && c <= 'z')
|| (c >= 'A' && c <= 'Z')
|| c == '_'
|| (c > '\x7f' && c.is_XID_start())
|| (c > '\x7f' && c.is_xid_start())
}

fn ident_continue(c: Option<char>) -> bool {
Expand All @@ -1395,7 +1395,7 @@ fn ident_continue(c: Option<char>) -> bool {
|| (c >= 'A' && c <= 'Z')
|| (c >= '0' && c <= '9')
|| c == '_'
|| (c > '\x7f' && c.is_XID_continue())
|| (c > '\x7f' && c.is_xid_continue())
}

#[cfg(test)]
Expand Down
25 changes: 25 additions & 0 deletions src/libunicode/u_char.rs
Original file line number Diff line number Diff line change
Expand Up @@ -167,17 +167,36 @@ pub trait UnicodeChar {
/// [UAX #31](http://unicode.org/reports/tr31/#NFKC_Modifications),
/// mostly similar to ID_Start but modified for closure under NFKx.
#[allow(non_snake_case)]
#[deprecated = "use is_xid_start"]
fn is_XID_start(self) -> bool;

/// Returns whether the specified character satisfies the 'XID_Start'
/// Unicode property.
///
/// 'XID_Start' is a Unicode Derived Property specified in
/// [UAX #31](http://unicode.org/reports/tr31/#NFKC_Modifications),
/// mostly similar to ID_Start but modified for closure under NFKx.
#[allow(non_snake_case)]
fn is_xid_start(self) -> bool;

/// Returns whether the specified `char` satisfies the 'XID_Continue'
/// Unicode property.
///
/// 'XID_Continue' is a Unicode Derived Property specified in
/// [UAX #31](http://unicode.org/reports/tr31/#NFKC_Modifications),
/// mostly similar to 'ID_Continue' but modified for closure under NFKx.
#[allow(non_snake_case)]
#[deprecated = "use is_xid_continue"]
fn is_XID_continue(self) -> bool;

/// Returns whether the specified `char` satisfies the 'XID_Continue'
/// Unicode property.
///
/// 'XID_Continue' is a Unicode Derived Property specified in
/// [UAX #31](http://unicode.org/reports/tr31/#NFKC_Modifications),
/// mostly similar to 'ID_Continue' but modified for closure under NFKx.
#[allow(non_snake_case)]
fn is_xid_continue(self) -> bool;

/// Indicates whether a character is in lowercase.
///
Expand Down Expand Up @@ -267,10 +286,16 @@ impl UnicodeChar for char {
}
}

#[deprecated = "use is_xid_start"]
fn is_XID_start(self) -> bool { derived_property::XID_Start(self) }

#[deprecated = "use is_xid_continue"]
fn is_XID_continue(self) -> bool { derived_property::XID_Continue(self) }

fn is_xid_start(self) -> bool { derived_property::XID_Start(self) }

fn is_xid_continue(self) -> bool { derived_property::XID_Continue(self) }

fn is_lowercase(self) -> bool {
match self {
'a' ... 'z' => true,
Expand Down

0 comments on commit f39c29d

Please sign in to comment.