[Java]: use a default instance for semantic versioning default valida…

…tor.
jh0x · Jul 18, 2022 · d1e7243 · d1e7243
1 parent 299a300
commit d1e7243
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/aeron-cluster/src/main/java/io/aeron/cluster/AppVersionValidator.java b/aeron-cluster/src/main/java/io/aeron/cluster/AppVersionValidator.java
@@ -24,6 +24,11 @@
  */
 public class AppVersionValidator
 {
+    /**
+     * Singleton instance of {@link org.agrona.SemanticVersion} version which can be used to avoid allocation.
+     */
+    public static final AppVersionValidator SEMANTIC_VERSIONING_VALIDATOR = new AppVersionValidator();
+
     /**
      * Check version compatibility between configured context appVersion and appVersion in
      * new leadership term or snapshot.

diff --git a/aeron-cluster/src/main/java/io/aeron/cluster/ConsensusModule.java b/aeron-cluster/src/main/java/io/aeron/cluster/ConsensusModule.java
@@ -1357,7 +1357,7 @@ public void conclude()
 
             if (null == appVersionValidator)
             {
-                appVersionValidator = new AppVersionValidator();
+                appVersionValidator = AppVersionValidator.SEMANTIC_VERSIONING_VALIDATOR;
             }
 
             if (null == clusterTimeConsumerSupplier)

diff --git a/aeron-cluster/src/main/java/io/aeron/cluster/service/ClusteredServiceContainer.java b/aeron-cluster/src/main/java/io/aeron/cluster/service/ClusteredServiceContainer.java
@@ -670,7 +670,7 @@ public void conclude()
 
             if (null == appVersionValidator)
             {
-                appVersionValidator = new AppVersionValidator();
+                appVersionValidator = AppVersionValidator.SEMANTIC_VERSIONING_VALIDATOR;
             }
 
             if (null == epochClock)