Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some minor fixes #51

Open
wants to merge 3 commits into
base: cpp
Choose a base branch
from
Open

some minor fixes #51

wants to merge 3 commits into from

Conversation

lucmann
Copy link

@lucmann lucmann commented Aug 22, 2024 •
edited
Loading

  • vk::Device::getQueryPoolResults (patch 1, 2)
  • vk::createResultValue -> vk::ResultValue (patch 3)

lucmann added 2 commits August 22, 2024 09:35
@lucmann
Fix pipelinestatistics example
98dc68c 
Fix compilation error: no matching function for call to
‘vk::Device::getQueryPoolResults<uint64_t>(vk::QueryPool&, int, int,
std::vector<long unsigned int>&, long unsigned int, vk::QueryResultFlagBits) const’

Building and testing vulkan environment:

```
GPU0:
apiVersion         = 1.3.255
driverVersion      = 0.0.1
vendorID           = 0x10005
deviceID           = 0x0000
deviceType         = PHYSICAL_DEVICE_TYPE_CPU
deviceName         = llvmpipe (LLVM 15.0.7, 256 bits)
driverID           = DRIVER_ID_MESA_LLVMPIPE
driverName         = llvmpipe
driverInfo         = Mesa 23.2.1-1ubuntu3.1~22.04.2 (LLVM 15.0.7)
conformanceVersion = 1.3.1.1
deviceUUID         = 6d657361-3233-2e32-2e31-2d3175627500
driverUUID         = 6c6c766d-7069-7065-5555-494400000000
```

Signed-off-by: Luc Ma <[email protected]>
@lucmann
Fix terraintessellation example
190f081 
Fix compilation error: no matching function for call to
‘vk::Device::getQueryPoolResults<uint64_t>(vk::QueryPool&, int, int,
std::array<long unsigned int, 2>&, long unsigned int, vk::QueryResultFlagBits) const’
152 |         device.getQueryPoolResults<uint64_t>(queryPool, 0, 1, pipelineStats, sizeof(uint64_t), vk::QueryResultFlagBits::e64);
    |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Luc Ma <[email protected]>
@lucmann
Copy link
Author

lucmann commented Aug 22, 2024

pipelinestatistics
terraintessellation

@lucmann
Use vk::ResultValue<> to adapt the latest vulkan-sdk
bdd0f69 
Since 8ba8294c86d0 ("Update for Vulkan-Docs 1.3.212") in the repo
[Vulkan-Headers](KhronosGroup/Vulkan-Headers@8ba8294#diff-a83f956c7aeb2b6dee7ffa2f249c0d98a2cfad6e157fe8438e372a5267afaeffL5986-R6086),
vk::createResultValue is renamed as vk::createResultValueType. And
in the recent versions (after 1.3.282), vk::createResultValueType has
been encapsulated under namespace ::detail, so presumably users have
to construct a vk::ResultValue<> on their own.

Signed-off-by: Luc Ma <[email protected]>
@lucmann lucmann force-pushed the fix-getQueryPoolResults branch from 197f18c to bdd0f69 Compare August 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucmann