[EWG] - Can now configure any line in nexus.properties... #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appropriate key in the 'nexus_properties' dict [2] Also fixed an issue whereby we weren't setting the permissions and ownership on the installation directory correct. [3] Also set the nexus user's default shell to '/bin/bash' as it is required to log in as this user to start Nexus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by setting the appropriate key in the 'nexus_properties' dict
[2] Also fixed an issue whereby we weren't setting the permissions and ownership on the installation directory correct (we were instead setting the permissions on the downloaded archive).
[3] Also set the nexus user's default shell to '/bin/bash' as it is required to log in as this user to start Nexus.
The behaviour of setting keys and values in
nexus.propertiesis now slightly different, because it is now a dict the whole dict gets replaced if the user re-specifies the dict outside of the role defaults. I have updated the README to explain the new behaviour. It felt a little counter-intuitive to me at first as I'm so used to Hiera's hash merging behviour, but given that Ansible doesn't default to dict merging I think it's reasonable. What do you think?