fix(test): browser.disconnect should not be awaited (puppeteer#4446)

browser.disconnect does not return a promise
jhob · May 21, 2019 · bad98ba · bad98ba
1 parent 90a1032
commit bad98ba
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/test/browser.spec.js b/test/browser.spec.js
@@ -57,7 +57,7 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
       const browserWSEndpoint = browser.wsEndpoint();
       const remoteBrowser = await puppeteer.connect({browserWSEndpoint});
       expect(remoteBrowser.process()).toBe(null);
-      await remoteBrowser.disconnect();
+      remoteBrowser.disconnect();
     });
   });
 
@@ -66,7 +66,7 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
       const browserWSEndpoint = browser.wsEndpoint();
       const newBrowser = await puppeteer.connect({browserWSEndpoint});
       expect(newBrowser.isConnected()).toBe(true);
-      await newBrowser.disconnect();
+      newBrowser.disconnect();
       expect(newBrowser.isConnected()).toBe(false);
     });
   });

diff --git a/test/browsercontext.spec.js b/test/browsercontext.spec.js
@@ -149,7 +149,7 @@ module.exports.addTests = function({testRunner, expect, puppeteer}) {
       });
       const contexts = remoteBrowser.browserContexts();
       expect(contexts.length).toBe(2);
-      await remoteBrowser.disconnect();
+      remoteBrowser.disconnect();
       await context.close();
     });
   });

diff --git a/test/launcher.spec.js b/test/launcher.spec.js
@@ -67,7 +67,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
         const page = await remote.newPage();
         const navigationPromise = page.goto(server.PREFIX + '/one-style.html', {timeout: 60000}).catch(e => e);
         await server.waitForRequest('/one-style.css');
-        await remote.disconnect();
+        remote.disconnect();
         const error = await navigationPromise;
         expect(error.message).toBe('Navigation failed because browser has disconnected!');
         await browser.close();
@@ -78,7 +78,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
         const remote = await puppeteer.connect({browserWSEndpoint: browser.wsEndpoint()});
         const page = await remote.newPage();
         const watchdog = page.waitForSelector('div', {timeout: 60000}).catch(e => e);
-        await remote.disconnect();
+        remote.disconnect();
         const error = await watchdog;
         expect(error.message).toContain('Protocol error');
         await browser.close();