deprecated support for the ArtifactDeployer Plugin

jibsheet · May 2, 2017 · 2b487a3 · 2b487a3
1 parent 7fe5188
commit 2b487a3
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 0 deletions.
diff --git a/docs/Home.md b/docs/Home.md
@@ -51,6 +51,8 @@ Browse the Jenkins issue tracker to see any [open issues](https://issues.jenkins
     deprecated, see [Migration](Migration#migrating-to-162)
   * Support for the [PostBuildScript Plugin](https://wiki.jenkins-ci.org/display/JENKINS/PostBuildScript+Plugin) is
     deprecated, see [Migration](Migration#migrating-to-162)
+  * Support for the [ArtifactDeployer Plugin](https://wiki.jenkins-ci.org/display/JENKINS/ArtifactDeployer+Plugin) is
+    deprecated, see [Migration](Migration#migrating-to-162)
 * 1.61 (April 17 2017)
   * Enhanced support for the [Stash Notifier Plugin](https://wiki.jenkins-ci.org/display/JENKINS/StashNotifier+Plugin)
     ([JENKINS-42900](https://issues.jenkins-ci.org/browse/JENKINS-42900),

diff --git a/docs/Migration.md b/docs/Migration.md
@@ -24,6 +24,12 @@ The [PostBuildScript Plugin](https://wiki.jenkins-ci.org/display/JENKINS/PostBui
 the Update Center due to [Security Vulnerabilities](https://jenkins.io/security/advisory/2017-04-10/). As a consequence
 the DSL support is [[deprecated|Deprecation-Policy]] and will be removed.
 
+### ArtifactDeployer Plugin
+
+The [ArtifactDeployer Plugin](https://wiki.jenkins-ci.org/display/JENKINS/ArtifactDeployer+Plugin) has been removed from
+the Update Center due to [Security Vulnerabilities](https://jenkins.io/security/advisory/2017-04-10/). As a consequence
+the DSL support is [[deprecated|Deprecation-Policy]] and will be removed.
+
 ## Migrating to 1.61
 
 ### Stash Notifier Plugin

diff --git a/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy b/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy
@@ -1569,6 +1569,7 @@ class PublisherContext extends AbstractExtensibleContext {
      * @since 1.39
      */
     @RequiresPlugin(id = 'artifactdeployer', minimumVersion = '0.33')
+    @Deprecated
     void artifactDeployer(@DslContext(ArtifactDeployerPublisherContext) Closure closure) {
         ArtifactDeployerPublisherContext context = new ArtifactDeployerPublisherContext()
         ContextHelper.executeInContext(closure, context)

diff --git a/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy b/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy
@@ -1026,6 +1026,7 @@ class StepContext extends AbstractExtensibleContext {
      * @since 1.39
      */
     @RequiresPlugin(id = 'artifactdeployer', minimumVersion = '0.33')
+    @Deprecated
     void artifactDeployer(@DslContext(ArtifactDeployerContext) Closure closure) {
         ArtifactDeployerContext context = new ArtifactDeployerContext()
         ContextHelper.executeInContext(closure, context)

diff --git a/...l-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy b/...l-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy
@@ -5220,6 +5220,7 @@ class PublisherContextSpec extends Specification {
             entries[0].value().empty
         }
         1 * jobManagement.requireMinimumPluginVersion('artifactdeployer', '0.33')
+        1 * jobManagement.logDeprecationWarning()
     }
 
     def 'call artifactDeployer with all options'() {
@@ -5278,6 +5279,7 @@ class PublisherContextSpec extends Specification {
             }
         }
         1 * jobManagement.requireMinimumPluginVersion('artifactdeployer', '0.33')
+        1 * jobManagement.logDeprecationWarning()
     }
 
     def 'slocCount with no options'() {

diff --git a/job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy b/job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy
@@ -3426,6 +3426,7 @@ class StepContextSpec extends Specification {
             }
         }
         1 * jobManagement.requireMinimumPluginVersion('artifactdeployer', '0.33')
+        1 * jobManagement.logDeprecationWarning()
     }
 
     def 'call artifactDeployer with all options'() {
@@ -3462,6 +3463,7 @@ class StepContextSpec extends Specification {
             }
         }
         1 * jobManagement.requireMinimumPluginVersion('artifactdeployer', '0.33')
+        1 * jobManagement.logDeprecationWarning()
     }
 
     def 'call managedScript with minimal options'() {