KAFKA-2730: use thread-id as metrics tags

Author: Guozhang Wang <[email protected]> Reviewers: Gwen Shapira Closes apache#416 from guozhangwang/K2730
jihyeong-ryu · Nov 4, 2015 · c30ee50 · c30ee50
1 parent aa73554
commit c30ee50
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/src/main/scala/kafka/server/ReplicaFetcherThread.scala b/core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
@@ -65,14 +65,16 @@ class ReplicaFetcherThread(name: String,
 
   private val sourceNode = new Node(sourceBroker.id, sourceBroker.host, sourceBroker.port)
 
+  // we need to include the full thread id composed of the broker and the thread index
+  // as the metrics tag to avoid metric name conflicts with more than one thread to the same broker
   private val networkClient = {
     val selector = new Selector(
       NetworkReceive.UNLIMITED,
       brokerConfig.connectionsMaxIdleMs,
       metrics,
       time,
       "replica-fetcher",
-      Map("broker-id" -> sourceBroker.id.toString).asJava,
+      Map("thread-id" -> name).asJava,
       false,
       ChannelBuilders.create(brokerConfig.interBrokerSecurityProtocol, Mode.CLIENT, LoginType.SERVER, brokerConfig.values)
     )