PY-33218 Don't warn about %-formatting argument type at tuple declara…

…tion site

that might be far away from the place where the corresponding formatting
operation was actually used.

python/src/com/jetbrains/python/inspections/PyStringFormatInspection.java

@@ -135,20 +135,28 @@ else if (rightExpression instanceof PyCallExpression) {
         else if (rightExpression instanceof PyParenthesizedExpression) {
           final PyExpression rhs = ((PyParenthesizedExpression)rightExpression).getContainedExpression();
           if (rhs != null) {
-            return inspectArguments(rhs, rhs);
+            return inspectArguments(rhs, problemTarget);
           }
         }
         else if (rightExpression instanceof PyTupleExpression) {
-          final PyExpression[] expressions = ((PyTupleExpression)rightExpression).getElements();
-          int i = 1;
-          for (PyExpression expression : expressions) {
-            final String formatSpec = myFormatSpec.get(Integer.toString(i));
-            if (formatSpec != null) {
-              checkExpressionType(expression, formatSpec, expression);
+          if (PsiTreeUtil.isAncestor(problemTarget, rightExpression, false)) {
+            final PyExpression[] expressions = ((PyTupleExpression)rightExpression).getElements();
+            int i = 1;
+            for (PyExpression expression : expressions) {
+              final String formatSpec = myFormatSpec.get(Integer.toString(i));
+              if (formatSpec != null) {
+                checkExpressionType(expression, formatSpec, expression);
+              }
+              ++i;
             }
-            ++i;
+            return expressions.length;
+          }
+          else {
+            final PyTupleType tupleType = (PyTupleType)myTypeEvalContext.getType(rightExpression);
+            assert tupleType != null;
+            matchEntireTupleTypes(problemTarget, tupleType);
+            return tupleType.getElementCount();
           }
-          return expressions.length;
         }
         else if (rightExpression instanceof PyDictLiteralExpression) {
           return inspectDict(rightExpression, problemTarget, false);

python/testData/inspections/PyStringFormatInspection/NoTypeMismatchOnElementsOfTupleDeclaration.py

@@ -0,0 +1,2 @@
+args = ('foo', 'bar')
+s = '%d %d' % <warning descr="Unexpected type (str, str)">args</warning>

python/testSrc/com/jetbrains/python/inspections/PyStringFormatInspectionTest.java

@@ -219,6 +219,11 @@ public void testSOEOnReassignedFormatArgument() {
     doTest();
   }
 
+  // PY-33218
+  public void testNoTypeMismatchOnElementsOfTupleDeclaration() {
+    doTest();
+  }
+
   @NotNull
   @Override
   protected Class<? extends PyInspection> getInspectionClass() {