Skip to content

Commit

Permalink
rtc: rtc-lp8788: use devm_request_threaded_irq()
Browse files Browse the repository at this point in the history
Use devm_request_threaded_irq() to make cleanup paths more simple.

Signed-off-by: Jingoo Han <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Jingoo Han authored and torvalds committed Feb 22, 2013
1 parent 3b759d7 commit 14b149e
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/rtc/rtc-lp8788.c
Original file line number Diff line number Diff line change
@@ -278,16 +278,11 @@ static int lp8788_alarm_irq_register(struct platform_device *pdev,

rtc->irq = irq_create_mapping(irqdm, irq);

return request_threaded_irq(rtc->irq, NULL, lp8788_alarm_irq_handler,
return devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
lp8788_alarm_irq_handler,
0, LP8788_ALM_IRQ, rtc);
}

static void lp8788_alarm_irq_unregister(struct lp8788_rtc *rtc)
{
if (rtc->irq)
free_irq(rtc->irq, rtc);
}

static int lp8788_rtc_probe(struct platform_device *pdev)
{
struct lp8788 *lp = dev_get_drvdata(pdev->dev.parent);
@@ -321,7 +316,6 @@ static int lp8788_rtc_remove(struct platform_device *pdev)
{
struct lp8788_rtc *rtc = platform_get_drvdata(pdev);

lp8788_alarm_irq_unregister(rtc);
rtc_device_unregister(rtc->rdev);
platform_set_drvdata(pdev, NULL);

0 comments on commit 14b149e

Please sign in to comment.