Skip to content

Commit

Permalink
gpio: exar: Fix iomap request
Browse files Browse the repository at this point in the history
The UART driver already maps the resource for us. Trying to do this here
only fails and leaves us with a non-working device.

Signed-off-by: Jan Kiszka <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Acked-by: Linus Walleij <[email protected]>
  • Loading branch information
jan-kiszka committed Jul 3, 2017
1 parent a39f2fe commit 8847f5f
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions drivers/gpio/gpio-exar.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,10 @@ static int gpio_exar_probe(struct platform_device *pdev)
int index, ret;

/*
* Map the pci device to get the register addresses.
* We will need to read and write those registers to control
* the GPIO pins.
* Using managed functions will save us from unmaping on exit.
* As the device is enabled using managed functions by the
* UART driver we can also use managed functions here.
* The UART driver must have mapped region 0 prior to registering this
* device - use it.
*/
p = pcim_iomap(pcidev, 0, 0);
p = pcim_iomap_table(pcidev)[0];
if (!p)
return -ENOMEM;

Expand Down

0 comments on commit 8847f5f

Please sign in to comment.