kvm: irqchip: fix memory leak

We were taking the exit path after checking ue->flags and return value of setup_routing_entry(), but 'e' was not freed incase of a failure. Signed-off-by: Sudip Mukherjee <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
jimmycarry · Sep 8, 2015 · ba60c41 · ba60c41
1 parent 3dfe6a5
commit ba60c41
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c
@@ -213,11 +213,15 @@ int kvm_set_irq_routing(struct kvm *kvm,
 			goto out;
 
 		r = -EINVAL;
-		if (ue->flags)
+		if (ue->flags) {
+			kfree(e);
 			goto out;
+		}
 		r = setup_routing_entry(new, e, ue);
-		if (r)
+		if (r) {
+			kfree(e);
 			goto out;
+		}
 		++ue;
 	}