Skip to content

Commit

Permalink
greth: fall through to common return statement on error
Browse files Browse the repository at this point in the history
There doesn't seem to be any reason to explicitly return
NETDEV_TX_OK as err is set to NETDEV_TX_OK in all cases that
reach this point.

Signed-off-by: Simon Horman <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
horms authored and davem330 committed Feb 26, 2010
1 parent e5e26d7 commit c43491d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/greth.c
Original file line number Diff line number Diff line change
Expand Up @@ -560,8 +560,6 @@ greth_start_xmit_gbit(struct sk_buff *skb, struct net_device *dev)
if (net_ratelimit())
dev_warn(greth->dev, "Could not create TX DMA mapping\n");
dev_kfree_skb(skb);
return NETDEV_TX_OK;

out:
return err;
}
Expand Down

0 comments on commit c43491d

Please sign in to comment.