Skip to content

Commit

Permalink
tomoyo: stop including hell knows what
Browse files Browse the repository at this point in the history
tomoyo/realpath.c needs exactly one include - that of common.h.  It pulls
everything the thing needs, without doing ridiculous garbage such as trying
to include ../../fs/internal.h.  If that alone doesn't scream "layering
violation", I don't know what does; and these days it's all for nothing,
since it fortunately does not use any symbols defined in there...

Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Jan 4, 2012
1 parent aa0a4cf commit c5dc332
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions security/tomoyo/realpath.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,7 @@
* Copyright (C) 2005-2011 NTT DATA CORPORATION
*/

#include <linux/types.h>
#include <linux/mount.h>
#include <linux/mnt_namespace.h>
#include <linux/fs_struct.h>
#include <linux/magic.h>
#include <linux/slab.h>
#include <net/sock.h>
#include "common.h"
#include "../../fs/internal.h"

/**
* tomoyo_encode2 - Encode binary string to ascii string.
Expand Down

0 comments on commit c5dc332

Please sign in to comment.