Skip to content

Commit

Permalink
pinctrl: mcp23s08: drop comment about missing irq support
Browse files Browse the repository at this point in the history
The driver supports using mcp23xxx as interrupt controller, so
let's drop all comments stating otherwise.

Signed-off-by: Sebastian Reichel <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
  • Loading branch information
sre authored and linusw committed May 23, 2017
1 parent ce9bd0a commit d8f4494
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
19 changes: 2 additions & 17 deletions drivers/pinctrl/pinctrl-mcp23s08.c
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
/*
* MCP23S08 SPI/I2C GPIO gpio expander driver
*
* The inputs and outputs of the mcp23s08, mcp23s17, mcp23008 and mcp23017 are
* supported.
* For the I2C versions of the chips (mcp23008 and mcp23017) generation of
* interrupts is also supported.
* The hardware of the SPI versions of the chips (mcp23s08 and mcp23s17) is
* also capable of generating interrupts, but the linux driver does not
* support that yet.
*/
/* MCP23S08 SPI/I2C GPIO driver */

#include <linux/kernel.h>
#include <linux/device.h>
Expand All @@ -27,7 +17,7 @@
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinconf-generic.h>

/**
/*
* MCP types supported by driver
*/
#define MCP_TYPE_S08 0
Expand Down Expand Up @@ -1131,11 +1121,6 @@ static int mcp23s08_probe(struct spi_device *spi)
}
data->ngpio = ngpio;

/* NOTE: these chips have a relatively sane IRQ framework, with
* per-signal masking and level/edge triggering. It's not yet
* handled here...
*/

return 0;
}

Expand Down
3 changes: 0 additions & 3 deletions include/linux/spi/mcp23s08.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@

/* FIXME driver should be able to handle IRQs... */

struct mcp23s08_platform_data {
/* For mcp23s08, up to 4 slaves (numbered 0..3) can share one SPI
* chipselect, each providing 1 gpio_chip instance with 8 gpios.
Expand Down

0 comments on commit d8f4494

Please sign in to comment.