Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
block: make disk_block_events() properly wait for work cancellation
disk_block_events() should guarantee that the event work is not in flight on return and once blocked it shouldn't issue further cancellations. Because there was no synchronization between the first blocker doing cancel_delayed_work_sync() and the following blockers, the following blockers could finish before cancellation was complete, which broke both guarantees - event work could be in flight and cancellation could happen after return. This bug triggered WARN_ON_ONCE() in disk_clear_events() reported in bug#34662. https://bugzilla.kernel.org/show_bug.cgi?id=34662 Fix it by adding an outer mutex which protects both block count manipulation and work cancellation. -v2: Use outer mutex instead of bit waitqueue per Linus. Signed-off-by: Tejun Heo <[email protected]> Tested-by: Sitsofe Wheeler <[email protected]> Reported-by: Sitsofe Wheeler <[email protected]> Reported-by: Borislav Petkov <[email protected]> Reported-by: Meelis Roos <[email protected]> Reported-by: Linus Torvalds <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Kay Sievers <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
- Loading branch information