Use LinkedHashSet for HttpHeaders.names() and add Javadoc about the p…

…erformance of names() and entries()
jimmyinterview · Dec 22, 2013 · ddacf78 · ddacf78
1 parent 0d437ba
commit ddacf78
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java
@@ -21,13 +21,13 @@
 import java.util.Calendar;
 import java.util.Date;
 import java.util.Iterator;
+import java.util.LinkedHashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.NoSuchElementException;
 import java.util.Set;
-import java.util.TreeSet;
 
 public class DefaultHttpHeaders extends HttpHeaders {
 
@@ -327,9 +327,7 @@ public boolean contains(CharSequence name, CharSequence value, boolean ignoreCas
 
     @Override
     public Set<String> names() {
-
-        Set<String> names = new TreeSet<String>(String.CASE_INSENSITIVE_ORDER);
-
+        Set<String> names = new LinkedHashSet<String>();
         HeaderEntry e = head.after;
         while (e != head) {
             names.add(e.getKey());

diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaders.java
@@ -27,8 +27,7 @@
 import java.util.Map.Entry;
 import java.util.Set;
 
-import static io.netty.handler.codec.http.HttpConstants.CR;
-import static io.netty.handler.codec.http.HttpConstants.LF;
+import static io.netty.handler.codec.http.HttpConstants.*;
 
 
 /**
@@ -1289,10 +1288,9 @@ protected HttpHeaders() { }
     public abstract List<String> getAll(CharSequence name);
 
     /**
-     * Returns the all headers that this message contains.
-     *
-     * @return A {@link List} of the header name-value entries, which will be
-     *         empty if no pairs are found
+     * Returns a new {@link List} that contains all headers in this object.  Note that modifying the
+     * returned {@link List} will not affect the state of this object.  If you intend to enumerate over the header
+     * entries only, use {@link #iterator()} instead, which has much less overhead.
      */
     public abstract List<Map.Entry<String, String>> entries();
 
@@ -1310,9 +1308,9 @@ protected HttpHeaders() { }
     public abstract boolean isEmpty();
 
     /**
-     * Gets a {@link Set} of all header names that this message contains
-     *
-     * @return A {@link Set} of all header names
+     * Returns a new {@link Set} that contains the names of all headers in this object.  Note that modifying the
+     * returned {@link Set} will not affect the state of this object.  If you intend to enumerate over the header
+     * entries only, use {@link #iterator()} instead, which has much less overhead.
      */
     public abstract Set<String> names();