Skip to content

Commit

Permalink
[lcm] Remove spurious deps from library code (RobotLocomotion#20308)
Browse files Browse the repository at this point in the history
This requires adding missing deps to some application code.
  • Loading branch information
jwnimmer-tri authored Oct 4, 2023
1 parent e67a130 commit 62a8c7f
Show file tree
Hide file tree
Showing 13 changed files with 32 additions and 7 deletions.
2 changes: 2 additions & 0 deletions examples/multibody/acrobot/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ drake_cc_binary(
deps = [
"//common:add_text_logging_gflags",
"//geometry:drake_visualizer",
"//lcm",
"//multibody/benchmarks/acrobot:make_acrobot_plant",
"//systems/analysis:implicit_euler_integrator",
"//systems/analysis:runge_kutta3_integrator",
Expand All @@ -39,6 +40,7 @@ drake_cc_binary(
],
deps = [
"//common:add_text_logging_gflags",
"//lcm",
"//multibody/benchmarks/acrobot:make_acrobot_plant",
"//multibody/parsing",
"//systems/analysis:simulator",
Expand Down
1 change: 1 addition & 0 deletions examples/multibody/cylinder_with_multicontact/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ drake_cc_binary(
deps = [
":populate_cylinder_plant",
"//common:add_text_logging_gflags",
"//lcm",
"//systems/analysis:simulator",
"//systems/framework:diagram",
"//systems/lcm:lcm_pubsub_system",
Expand Down
1 change: 1 addition & 0 deletions examples/multibody/inclined_plane_with_body/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ drake_cc_binary(
],
deps = [
"//common:add_text_logging_gflags",
"//lcm",
"//multibody/benchmarks/inclined_plane",
"//multibody/plant:contact_results_to_lcm",
"//systems/analysis:simulator",
Expand Down
1 change: 1 addition & 0 deletions examples/multibody/pendulum/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ drake_cc_binary(
test_rule_args = ["--target_realtime_rate=0.0"],
deps = [
"//geometry:drake_visualizer",
"//lcm",
"//multibody/benchmarks/pendulum",
"//systems/analysis:implicit_euler_integrator",
"//systems/analysis:runge_kutta3_integrator",
Expand Down
1 change: 1 addition & 0 deletions examples/multibody/rolling_sphere/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ drake_cc_binary(
deps = [
":populate_ball_plant",
"//common:add_text_logging_gflags",
"//lcm",
"//multibody/plant:contact_results_to_lcm",
"//systems/analysis:simulator",
"//systems/analysis:simulator_gflags",
Expand Down
3 changes: 3 additions & 0 deletions examples/scene_graph/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ drake_cc_binary(
"//geometry:drake_visualizer",
"//geometry:scene_graph",
"//geometry/render_vtk",
"//lcm",
"//systems/analysis:simulator",
"//systems/framework:diagram",
"//systems/lcm:lcm_pubsub_system",
Expand All @@ -61,6 +62,7 @@ drake_cc_binary(
deps = [
"//geometry:drake_visualizer",
"//geometry:scene_graph",
"//lcm",
"//lcmtypes:contact_results_for_viz",
"//systems/analysis:simulator",
"//systems/framework:diagram",
Expand Down Expand Up @@ -107,6 +109,7 @@ drake_cc_binary(
":solar_system",
"//geometry:drake_visualizer",
"//geometry:scene_graph",
"//lcm",
"//systems/analysis:simulator",
"//systems/framework:diagram",
"//systems/primitives:constant_vector_source",
Expand Down
11 changes: 8 additions & 3 deletions geometry/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,20 @@ drake_cc_library(
name = "drake_visualizer",
srcs = ["drake_visualizer.cc"],
hdrs = ["drake_visualizer.h"],
deps = [
interface_deps = [
":drake_visualizer_params",
":geometry_roles",
":geometry_version",
":scene_graph",
"//common:essential",
"//lcm:drake_lcm",
"//lcmtypes:viewer",
"//lcm:interface",
"//systems/framework:context",
"//systems/framework:leaf_system",
],
deps = [
"//lcm:drake_lcm",
"//lcmtypes:viewer",
],
)

drake_cc_library(
Expand Down Expand Up @@ -689,6 +692,8 @@ drake_cc_googletest(
":drake_visualizer",
"//common/test_utilities:eigen_matrix_compare",
"//common/test_utilities:expect_throws_message",
"//lcm",
"//lcmtypes:viewer",
"//systems/analysis:simulator",
],
)
Expand Down
1 change: 1 addition & 0 deletions geometry/profiling/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ drake_cc_binary(
"//common",
"//geometry:drake_visualizer",
"//geometry:scene_graph",
"//lcm",
"//lcmtypes:contact_results_for_viz",
"//systems/analysis:explicit_euler_integrator",
"//systems/analysis:simulator",
Expand Down
1 change: 1 addition & 0 deletions geometry/render_gltf_client/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ drake_cc_binary(
"//geometry:drake_visualizer",
"//geometry:scene_graph",
"//geometry/render_vtk",
"//lcm",
"//multibody/parsing",
"//multibody/plant",
"//systems/analysis:simulator",
Expand Down
1 change: 1 addition & 0 deletions manipulation/kuka_iiwa/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ drake_cc_googletest(
":build_iiwa_control",
":iiwa_constants",
"//common:find_resource",
"//lcm",
"//manipulation/util:make_arm_controller_model",
"//multibody/parsing:model_instance_info",
"//multibody/parsing:parser",
Expand Down
1 change: 1 addition & 0 deletions manipulation/schunk_wsg/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ drake_cc_googletest(
":build_schunk_wsg_control",
":schunk_wsg_lcm",
"//common:find_resource",
"//lcm",
"//multibody/parsing:parser",
"//multibody/plant",
"//systems/analysis:simulator",
Expand Down
1 change: 1 addition & 0 deletions multibody/plant/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ drake_cc_googletest(
"//common/test_utilities:eigen_matrix_compare",
"//common/test_utilities:expect_throws_message",
"//geometry:drake_visualizer",
"//lcm",
"//math:geometric_transform",
"//multibody/plant:contact_results_to_lcm",
"//systems/analysis:implicit_euler_integrator",
Expand Down
14 changes: 10 additions & 4 deletions systems/lcm/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,14 @@ drake_cc_library(
name = "lcm_publisher_system",
srcs = ["lcm_publisher_system.cc"],
hdrs = ["lcm_publisher_system.h"],
deps = [
interface_deps = [
":serializer",
"//lcm:drake_lcm",
"//lcm:interface",
"//systems/framework:leaf_system",
],
deps = [
"//lcm:drake_lcm",
],
)

drake_cc_library(
Expand All @@ -62,11 +65,14 @@ drake_cc_library(
name = "lcm_subscriber_system",
srcs = ["lcm_subscriber_system.cc"],
hdrs = ["lcm_subscriber_system.h"],
deps = [
interface_deps = [
":serializer",
"//lcm:drake_lcm",
"//lcm:interface",
"//systems/framework:leaf_system",
],
deps = [
"//lcm:drake_lcm",
],
)

drake_cc_library(
Expand Down

0 comments on commit 62a8c7f

Please sign in to comment.