Use 'future.seed' and 'progressr' in the future framework #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycl6
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR with similar changes has been submitted before to CellChat v1 to fix and improve a few issues that seems to have persisted into the v2 version.
This PR changes how some functions deal with sequential and parallel processes.
Following the suggestion in sqjin/CellChat#424 and discussion in sqjin/CellChat#140 regarding the missing
future.seedsetting, I dropped the detection of number of cores and theifelseswitch betweenpbapply::pbsapplyandfuture.apply::future_sapplyfor sequential and parallel computing respectively, and opted to use theprogressrpackage for progress updates, which is the recommended way in thefutureframework.I also parallelise the calculation of
Pboot(default with 100 permutations) in thecomputeCommunProbfunction, which was running sequentially previously. The update should significantly speed upcomputeCommunProb().