Fix descriptions and add suspend/resume/vmstatus #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you incorporated it into code. Great thanx! |
|
Yeah, I forgot to reply and close this PR after merging your changes. Sorry about that. And thanks for your contribution! |
|
About permissions for tun device, this should be handled by udev (mdev). It should work out-of-box on Alpine; if it doesn't for you, please open an issue on bugs.alpinelinux.org. |
|
No problem :-). About tun/tap - I suspect it is not Alpine fault, but it is related to openvz as outside container (vpsfree.cz). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi (Ahoj!),
thanx for great qemu instrumentation. I love simplicity of Alpine Linux, openrc ...
I fixed description variable names and added ability to suspend/resume and check status.
In my enviroment, it is necessary to add permissions for qemu to /dev/net/tun, but I am not sure if this is general problem. I solved it by quick hack - added:
chgrp $group /dev/net/tun && chmod g+rw /dev/net/tunto start().
Next think is, that I have something like this:
echo "---
date +'%Y-%m-%d %T'Starting "$VM_NAME" ---" >> $logfilewhile starting or stopping VM.
If you want I can make another PR with this changes.
Have a great day!
Měj se hezky!