Skip to content

Commit

Permalink
dt-bindings: mailbox : arm,mhu: Use examples with matching schema
Browse files Browse the repository at this point in the history
Currently the example provided in arm,mhu schema complains as below:

    Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml :0:0:
    /example-0/soc/scb@2e000000: failed to match any schema with compatible:
    ['fujitsu,mb86s70-scb-1.0']

Fix the same using examples based on Juno platform. The old SCPI firmware
used MHU with standard 32-bit data transfer protocol while the new SCMI
firmware uses MHU and expects to be used in doorbell mode. Update example
with SCPI and SCMI firmware nodes to demonstrate both 32-bit data transfer
and doorbell mode of MHU operations

Cc: Rob Herring <[email protected]>
Cc: Viresh Kumar <[email protected]>
Signed-off-by: Sudeep Holla <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Rob Herring <[email protected]>
  • Loading branch information
sudeep-holla authored and robherring committed Jun 4, 2021
1 parent 61b8ac9 commit 3a32f22
Showing 1 changed file with 38 additions and 10 deletions.
48 changes: 38 additions & 10 deletions Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,19 @@ examples:
clocks = <&clock 0 2 1>;
clock-names = "apb_pclk";
};
};
mhu_client_scb: scb@2e000000 {
compatible = "fujitsu,mb86s70-scb-1.0";
reg = <0 0x2e000000 0 0x4000>;
firmware {
scpi {
compatible = "arm,scpi";
mboxes = <&mhuA 1>; /* HP-NonSecure */
shmem = <&cpu_scp_hpri>; /* HP-NonSecure */
scpi_devpd: power-controller {
compatible = "arm,scpi-power-domains";
num-domains = <2>;
#power-domain-cells = <1>;
};
};
};
Expand All @@ -125,16 +133,36 @@ examples:
clocks = <&clock 0 2 1>;
clock-names = "apb_pclk";
};
};
scpi {
compatible = "arm,scpi";
mboxes = <&mhuB 1 4>; /* HP-NonSecure, 5th doorbell */
shmem = <&cpu_scp_hpri>; /* HP-NonSecure */
firmware {
scmi {
compatible = "arm,scmi";
mboxes = <&mhuB 0 0>, /* LP-NonSecure, 1st doorbell */
<&mhuB 0 1>; /* LP-NonSecure, 2nd doorbell */
mbox-names = "tx", "rx";
shmem = <&cpu_scp_lpri0>,
<&cpu_scp_lpri1>;
scpi_devpd: power-controller {
compatible = "arm,scpi-power-domains";
num-domains = <2>;
#address-cells = <1>;
#size-cells = <0>;
scmi_devpd: protocol@11 {
reg = <0x11>;
#power-domain-cells = <1>;
};
scmi_dvfs: protocol@13 {
reg = <0x13>;
#clock-cells = <1>;
mboxes = <&mhuB 1 2>, /* HP-NonSecure, 3rd doorbell */
<&mhuB 1 3>; /* HP-NonSecure, 4th doorbell */
mbox-names = "tx", "rx";
shmem = <&cpu_scp_hpri0>,
<&cpu_scp_hpri1>;
};
};
};
...

0 comments on commit 3a32f22

Please sign in to comment.