Skip to content

Commit

Permalink
hwmon: (it87) Add support for IT8786E
Browse files Browse the repository at this point in the history
IT8786E is mostly compatible with IT8771 / IT8772.
Parameters determined by testing various combinations.

Reviewed-by: Jean Delvare <[email protected]>
Signed-off-by: Thomas Lorblanches <[email protected]>
[Guenter Roeck: merged from github, addressed review comments]
Signed-off-by: Guenter Roeck <[email protected]>
  • Loading branch information
Zlika authored and groeck committed Mar 9, 2015
1 parent 32dd7c4 commit a0c1424
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 9 deletions.
6 changes: 5 additions & 1 deletion Documentation/hwmon/it87
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ Supported chips:
Prefix: 'it8783'
Addresses scanned: from Super I/O config space (8 I/O ports)
Datasheet: Not publicly available
* IT8786E
Prefix: 'it8786'
Addresses scanned: from Super I/O config space (8 I/O ports)
Datasheet: Not publicly available
* SiS950 [clone of IT8705F]
Prefix: 'it87'
Addresses scanned: from Super I/O config space (8 I/O ports)
Expand Down Expand Up @@ -100,7 +104,7 @@ Description

This driver implements support for the IT8603E, IT8623E, IT8705F, IT8712F,
IT8716F, IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8758E, IT8771E,
IT8772E, IT8781F, IT8782F, IT8783E/F, and SiS950 chips.
IT8772E, IT8781F, IT8782F, IT8783E/F, IT8786E, and SiS950 chips.

These chips are 'Super I/O chips', supporting floppy disks, infrared ports,
joysticks and other miscellaneous stuff. For hardware monitoring, they
Expand Down
4 changes: 2 additions & 2 deletions drivers/hwmon/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,8 @@ config SENSORS_IT87
help
If you say yes here you get support for ITE IT8705F, IT8712F,
IT8716F, IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8758E,
IT8771E, IT8772E, IT8781F, IT8782F, IT8783E/F and IT8603E
sensor chips, and the SiS950 clone.
IT8771E, IT8772E, IT8781F, IT8782F, IT8783E/F, IT8786E,
and IT8603E sensor chips, and the SiS950 clone.

This driver can also be built as a module. If so, the module
will be called it87.
Expand Down
22 changes: 16 additions & 6 deletions drivers/hwmon/it87.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
* IT8781F Super I/O chip w/LPC interface
* IT8782F Super I/O chip w/LPC interface
* IT8783E/F Super I/O chip w/LPC interface
* IT8786E Super I/O chip w/LPC interface
* Sis950 A clone of the IT8705F
*
* Copyright (C) 2001 Chris Gauthron
Expand Down Expand Up @@ -67,7 +68,7 @@
#define DRVNAME "it87"

enum chips { it87, it8712, it8716, it8718, it8720, it8721, it8728, it8771,
it8772, it8781, it8782, it8783, it8603 };
it8772, it8781, it8782, it8783, it8786, it8603 };

static unsigned short force_id;
module_param(force_id, ushort, 0);
Expand Down Expand Up @@ -150,6 +151,7 @@ static inline void superio_exit(void)
#define IT8781F_DEVID 0x8781
#define IT8782F_DEVID 0x8782
#define IT8783E_DEVID 0x8783
#define IT8786E_DEVID 0x8786
#define IT8603E_DEVID 0x8603
#define IT8623E_DEVID 0x8623
#define IT87_ACT_REG 0x30
Expand Down Expand Up @@ -335,6 +337,12 @@ static const struct it87_devices it87_devices[] = {
| FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG,
.old_peci_mask = 0x4,
},
[it8786] = {
.name = "it8786",
.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
| FEAT_TEMP_OFFSET | FEAT_TEMP_PECI,
.peci_mask = 0x07,
},
[it8603] = {
.name = "it8603",
.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
Expand Down Expand Up @@ -1789,6 +1797,9 @@ static int __init it87_find(unsigned short *address,
case IT8783E_DEVID:
sio_data->type = it8783;
break;
case IT8786E_DEVID:
sio_data->type = it8786;
break;
case IT8603E_DEVID:
case IT8623E_DEVID:
sio_data->type = it8603;
Expand Down Expand Up @@ -1816,8 +1827,8 @@ static int __init it87_find(unsigned short *address,
sio_data->revision = superio_inb(DEVREV) & 0x0f;
pr_info("Found IT%04x%c chip at 0x%x, revision %d\n", chip_type,
chip_type == 0x8771 || chip_type == 0x8772 ||
chip_type == 0x8603 ? 'E' : 'F', *address,
sio_data->revision);
chip_type == 0x8786 || chip_type == 0x8603 ? 'E' : 'F',
*address, sio_data->revision);

/* in8 (Vbat) is always internal */
sio_data->internal = (1 << 2);
Expand Down Expand Up @@ -1987,9 +1998,8 @@ static int __init it87_find(unsigned short *address,
if (reg & (1 << 0))
sio_data->internal |= (1 << 0);
if ((reg & (1 << 1)) || sio_data->type == it8721 ||
sio_data->type == it8728 ||
sio_data->type == it8771 ||
sio_data->type == it8772)
sio_data->type == it8728 || sio_data->type == it8771 ||
sio_data->type == it8772 || sio_data->type == it8786)
sio_data->internal |= (1 << 1);

/*
Expand Down

0 comments on commit a0c1424

Please sign in to comment.