Skip to content

Commit

Permalink
HID: intel-ish: Supply some missing param descriptions
Browse files Browse the repository at this point in the history
Fixes the following W=1 kernel build warning(s):

 drivers/hid/intel-ish-hid/ishtp/bus.c:173: warning: Function parameter or member 'fw_client' not described in 'ishtp_get_fw_client_id'
 drivers/hid/intel-ish-hid/ishtp/bus.c:845: warning: Function parameter or member 'device' not described in 'ishtp_device'
 drivers/hid/intel-ish-hid/ishtp/bus.c:858: warning: Function parameter or member 'device' not described in 'ishtp_get_pci_device'
 drivers/hid/intel-ish-hid/ishtp/bus.c:871: warning: Function parameter or member 'cl_device' not described in 'ishtp_trace_callback'
 drivers/hid/intel-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset'

Cc: Srinivas Pandruvada <[email protected]>
Cc: Jiri Kosina <[email protected]>
Cc: Benjamin Tissoires <[email protected]>
Cc: "Uwe Kleine-König" <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>
Signed-off-by: Benjamin Tissoires <[email protected]>
  • Loading branch information
Lee Jones authored and bentiss committed Apr 7, 2021
1 parent 3977e00 commit d5831be
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/hid/intel-ish-hid/ishtp/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ EXPORT_SYMBOL(ishtp_fw_cl_get_client);

/**
* ishtp_get_fw_client_id() - Get fw client id
* @fw_client: firmware client used to fetch the ID
*
* This interface is used to reset HW get FW client id.
*
Expand Down Expand Up @@ -835,6 +836,7 @@ int ishtp_use_dma_transfer(void)

/**
* ishtp_device() - Return device pointer
* @device: ISH-TP client device instance
*
* This interface is used to return device pointer from ishtp_cl_device
* instance.
Expand All @@ -851,6 +853,7 @@ EXPORT_SYMBOL(ishtp_device);
* ishtp_get_pci_device() - Return PCI device dev pointer
* This interface is used to return PCI device pointer
* from ishtp_cl_device instance.
* @device: ISH-TP client device instance
*
* Return: device *.
*/
Expand All @@ -862,6 +865,7 @@ EXPORT_SYMBOL(ishtp_get_pci_device);

/**
* ishtp_trace_callback() - Return trace callback
* @cl_device: ISH-TP client device instance
*
* This interface is used to return trace callback function pointer.
*
Expand All @@ -875,6 +879,7 @@ EXPORT_SYMBOL(ishtp_trace_callback);

/**
* ish_hw_reset() - Call HW reset IPC callback
* @dev: ISHTP device instance
*
* This interface is used to reset HW in case of error.
*
Expand Down

0 comments on commit d5831be

Please sign in to comment.