mm: frontswap: make all branches of if statement in put page consistent

Currently it has a complex structure where different things are compared at each branch. Simplify that and make both branches look similar. Reviewed-by: Minchan Kim <[email protected]> Signed-off-by: Sasha Levin <[email protected]> Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>
jix · Jun 11, 2012 · d9674dd · d9674dd
1 parent 69217b4
commit d9674dd
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/mm/frontswap.c b/mm/frontswap.c
@@ -140,16 +140,16 @@ int __frontswap_store(struct page *page)
 		inc_frontswap_succ_stores();
 		if (!dup)
 			atomic_inc(&sis->frontswap_pages);
-	} else if (dup) {
+	} else {
 		/*
 		  failed dup always results in automatic invalidate of
 		  the (older) page from frontswap
 		 */
-		frontswap_clear(sis, offset);
-		atomic_dec(&sis->frontswap_pages);
-		inc_frontswap_failed_stores();
-	} else {
 		inc_frontswap_failed_stores();
+		if (dup) {
+			frontswap_clear(sis, offset);
+			atomic_dec(&sis->frontswap_pages);
+		}
 	}
 	if (frontswap_writethrough_enabled)
 		/* report failure so swap also writes to swap device */