forked from AppFlowy-IO/appflowy-editor
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: unable to click the items in a long list (AppFlowy-IO#725)
- Loading branch information
Showing
6 changed files
with
138 additions
and
169 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
lib/src/editor/editor_component/service/selection/shared.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| import 'dart:math' as math; | ||
|
|
||
| import 'package:appflowy_editor/appflowy_editor.dart'; | ||
| import 'package:flutter/material.dart'; | ||
|
|
||
| extension EditorStateSelection on EditorState { | ||
| List<Node> getVisibleNodes(EditorScrollController controller) { | ||
| final List<Node> sortedNodes = []; | ||
| final positions = controller.visibleRangeNotifier.value; | ||
| // https://github.com/AppFlowy-IO/AppFlowy/issues/3651 | ||
| final min = math.max(positions.$1 - 1, 0); | ||
| final max = positions.$2; | ||
| if (min < 0 || max < 0) { | ||
| return sortedNodes; | ||
| } | ||
|
|
||
| int i = -1; | ||
| for (final child in document.root.children) { | ||
| i++; | ||
| if (min > i) { | ||
| continue; | ||
| } | ||
| if (i > max) { | ||
| break; | ||
| } | ||
| sortedNodes.add(child); | ||
| } | ||
| return sortedNodes; | ||
| } | ||
|
|
||
| Node? getNodeInOffset( | ||
| List<Node> sortedNodes, | ||
| Offset offset, | ||
| int start, | ||
| int end, | ||
| ) { | ||
| if (start < 0 && end >= sortedNodes.length) { | ||
| return null; | ||
| } | ||
|
|
||
| var min = _findCloseNode( | ||
| sortedNodes, | ||
| start, | ||
| end, | ||
| (rect) => rect.bottom <= offset.dy, | ||
| ); | ||
|
|
||
| final filteredNodes = List.of(sortedNodes) | ||
| ..retainWhere((n) => n.rect.bottom == sortedNodes[min].rect.bottom); | ||
| min = 0; | ||
| if (filteredNodes.length > 1) { | ||
| min = _findCloseNode( | ||
| sortedNodes, | ||
| 0, | ||
| filteredNodes.length - 1, | ||
| (rect) => rect.right <= offset.dx, | ||
| ); | ||
| } | ||
|
|
||
| final node = filteredNodes[min]; | ||
| if (node.children.isNotEmpty && | ||
| node.children.first.renderBox != null && | ||
| node.children.first.rect.top <= offset.dy) { | ||
| final children = node.children.toList(growable: false) | ||
| ..sort( | ||
| (a, b) => a.rect.bottom != b.rect.bottom | ||
| ? a.rect.bottom.compareTo(b.rect.bottom) | ||
| : a.rect.left.compareTo(b.rect.left), | ||
| ); | ||
|
|
||
| return getNodeInOffset( | ||
| children, | ||
| offset, | ||
| 0, | ||
| children.length - 1, | ||
| ); | ||
| } | ||
| return node; | ||
| } | ||
|
|
||
| int _findCloseNode( | ||
| List<Node> sortedNodes, | ||
| int start, | ||
| int end, | ||
| bool Function(Rect rect) compare, | ||
| ) { | ||
| var min = start; | ||
| var max = end; | ||
| while (min <= max) { | ||
| final mid = min + ((max - min) >> 1); | ||
| final rect = sortedNodes[mid].rect; | ||
| if (compare(rect)) { | ||
| min = mid + 1; | ||
| } else { | ||
| max = mid - 1; | ||
| } | ||
| } | ||
| return min.clamp(start, end); | ||
| } | ||
| } |
Oops, something went wrong.