Create admin API to list namespaces (temporalio#2170)

jleach4 · Nov 12, 2021 · b9edf16 · b9edf16
1 parent 725a4de
commit b9edf16
Show file tree

Hide file tree

Showing 10 changed files with 1,368 additions and 308 deletions.
diff --git a/api/adminservice/v1/request_response.pb.go b/api/adminservice/v1/request_response.pb.go
diff --git a/api/adminservice/v1/service.pb.go b/api/adminservice/v1/service.pb.go
diff --git a/api/adminservicemock/v1/service.pb.mock.go b/api/adminservicemock/v1/service.pb.mock.go
diff --git a/client/admin/client.go b/client/admin/client.go
@@ -245,6 +245,20 @@ func (c *clientImpl) GetReplicationMessages(
 	return client.GetReplicationMessages(ctx, request, opts...)
 }
 
+func (c *clientImpl) ListNamespaces(
+	ctx context.Context,
+	request *adminservice.ListNamespacesRequest,
+	opts ...grpc.CallOption,
+) (*adminservice.ListNamespacesResponse, error) {
+	client, err := c.getRandomClient()
+	if err != nil {
+		return nil, err
+	}
+	ctx, cancel := c.createContext(ctx)
+	defer cancel()
+	return client.ListNamespaces(ctx, request, opts...)
+}
+
 func (c *clientImpl) GetNamespaceReplicationMessages(
 	ctx context.Context,
 	request *adminservice.GetNamespaceReplicationMessagesRequest,

diff --git a/client/admin/metricClient.go b/client/admin/metricClient.go
@@ -281,6 +281,24 @@ func (c *metricClient) GetReplicationMessages(
 	return resp, err
 }
 
+func (c *metricClient) ListNamespaces(
+	ctx context.Context,
+	request *adminservice.ListNamespacesRequest,
+	opts ...grpc.CallOption,
+) (*adminservice.ListNamespacesResponse, error) {
+
+	c.metricsClient.IncCounter(metrics.AdminClientListNamespacesScope, metrics.ClientRequests)
+
+	sw := c.metricsClient.StartTimer(metrics.AdminClientListNamespacesScope, metrics.ClientLatency)
+	resp, err := c.client.ListNamespaces(ctx, request, opts...)
+	sw.Stop()
+
+	if err != nil {
+		c.metricsClient.IncCounter(metrics.AdminClientListNamespacesScope, metrics.ClientFailures)
+	}
+	return resp, err
+}
+
 func (c *metricClient) GetNamespaceReplicationMessages(
 	ctx context.Context,
 	request *adminservice.GetNamespaceReplicationMessagesRequest,

diff --git a/client/admin/retryableClient.go b/client/admin/retryableClient.go
@@ -256,6 +256,22 @@ func (c *retryableClient) GetReplicationMessages(
 	return resp, err
 }
 
+func (c *retryableClient) ListNamespaces(
+	ctx context.Context,
+	request *adminservice.ListNamespacesRequest,
+	opts ...grpc.CallOption,
+) (*adminservice.ListNamespacesResponse, error) {
+
+	var resp *adminservice.ListNamespacesResponse
+	op := func() error {
+		var err error
+		resp, err = c.client.ListNamespaces(ctx, request, opts...)
+		return err
+	}
+	err := backoff.Retry(op, c.policy, c.isRetryable)
+	return resp, err
+}
+
 func (c *retryableClient) GetNamespaceReplicationMessages(
 	ctx context.Context,
 	request *adminservice.GetNamespaceReplicationMessagesRequest,