Skip to content

Commit

Permalink
Upgrade golang to 1.17.3 (temporalio#2240)
Browse files Browse the repository at this point in the history
* Upgrade golang to 1.17.3
* Update base image version
  • Loading branch information
yiminc authored Nov 30, 2021
1 parent 171d228 commit d490009
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.17
go-version: 1.17.3
- name: Get build date
id: date
run: echo "::set-output name=date::$(date '+%F-%T')"
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This doc is for contributors to Temporal Server (hopefully that's you!)
## Prerequisites

### Build prerequisites
* [Go Lang](https://golang.org/) (minimum version required is 1.17):
* [Go Lang](https://golang.org/) (minimum version required is 1.17.3):
- Install on macOS with `brew install go`.
- Install on Ubuntu with `sudo apt install golang`.
* [Protocol buffers compiler](https://github.com/protocolbuffers/protobuf/) (only if you are going to change `proto` files):
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG TARGET=server
ARG BASE_BUILDER_IMAGE=temporalio/base-builder:1.4.0
ARG BASE_SERVER_IMAGE=temporalio/base-server:1.3.0
ARG BASE_ADMIN_TOOLS_IMAGE=temporalio/base-admin-tools:1.2.0
ARG BASE_BUILDER_IMAGE=temporalio/base-builder:1.5.0
ARG BASE_SERVER_IMAGE=temporalio/base-server:1.4.0
ARG BASE_ADMIN_TOOLS_IMAGE=temporalio/base-admin-tools:1.3.0
ARG GOPROXY

##### Temporal builder #####
Expand Down
2 changes: 1 addition & 1 deletion docker/base-images/base-builder.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# alpine3.14 requires docker 20.10: https://gitlab.alpinelinux.org/alpine/aports/-/issues/12396
FROM golang:1.17-alpine3.13 AS base-builder
FROM golang:1.17.3-alpine3.13 AS base-builder

RUN apk add --update --no-cache \
make \
Expand Down
2 changes: 1 addition & 1 deletion docker/base-images/base-ci-builder.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# alpine3.14 requires docker 20.10: https://gitlab.alpinelinux.org/alpine/aports/-/issues/12396
# Buildkite elastic stack needs to be upgraded to the version which has docker 20.10.0 (at least).
FROM golang:1.17-alpine3.13 AS base-ci-builder
FROM golang:1.17.3-alpine3.13 AS base-ci-builder

RUN apk add --update --no-cache \
make \
Expand Down
2 changes: 1 addition & 1 deletion docker/base-images/base-server.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
##### dockerize builder: built from source to support arm & x86 #####
# alpine3.14 requires docker 20.10: https://gitlab.alpinelinux.org/alpine/aports/-/issues/12396
FROM golang:1.17-alpine3.13 AS dockerize-builder
FROM golang:1.17.3-alpine3.13 AS dockerize-builder

RUN apk add --update --no-cache \
git
Expand Down

0 comments on commit d490009

Please sign in to comment.