Skip to content

Commit

Permalink
Fix replication task processor when converting to replication task (t…
Browse files Browse the repository at this point in the history
  • Loading branch information
samarabbas authored May 17, 2020
1 parent 031bdcf commit fb986a6
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
14 changes: 14 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"version": "0.2.0",
"configurations": [

{
"name": "Debug Server",
"type": "go",
Expand All @@ -12,6 +13,19 @@
"start",
]
},
{
"name": "Debug Active Server",
"type": "go",
"request": "launch",
"mode": "debug",
"program": "${workspaceFolder}/cmd/server",
"cwd": "${workspaceFolder}",
"args": [
"--env",
"development_active",
"start",
]
},
{
"name": "Debug CLI Namespace Describe",
"type": "go",
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/dataInterfaces.go
Original file line number Diff line number Diff line change
Expand Up @@ -1540,7 +1540,7 @@ func (d *DecisionTask) SetTaskID(id int64) {
}

// GetVisibilityTimestamp get the visibility timestamp
func (d ReplicationTaskInfoWrapper) GetVisibilityTimestamp() *types.Timestamp {
func (d *ReplicationTaskInfoWrapper) GetVisibilityTimestamp() *types.Timestamp {
return &types.Timestamp{}
}

Expand Down
2 changes: 1 addition & 1 deletion service/history/replicatorQueueProcessor.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ func (p *replicatorQueueProcessorImpl) processSyncActivityTask(
func (p *replicatorQueueProcessorImpl) processHistoryReplicationTask(
task *persistenceblobs.ReplicationTaskInfo,
) error {
replicationTask, err := p.toReplicationTask(context.Background(), persistence.ReplicationTaskInfoWrapper{task})
replicationTask, err := p.toReplicationTask(context.Background(), &persistence.ReplicationTaskInfoWrapper{task})
if err != nil || replicationTask == nil {
return err
}
Expand Down

0 comments on commit fb986a6

Please sign in to comment.