Skip to content

Commit

Permalink
net: dsa: bcm_sf2: Get VLAN_PORT_MASK from b53_device
Browse files Browse the repository at this point in the history
While migrating the bcm_sf2 driver to use b53_common, we left a small
piece untouched where we kept our local copy of the per-port
port_vlan_ctl bitmask value. This value is now maintained by b53_device
so we need to use it instead of our local (and now stale) copy of it.

Fixes: f458995 ("net: dsa: bcm_sf2: Utilize core B53 driver when possible")
Signed-off-by: Florian Fainelli <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
ffainelli authored and davem330 committed Sep 12, 2016
1 parent 8fee315 commit 0215492
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/net/dsa/bcm_sf2.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ static int bcm_sf2_port_setup(struct dsa_switch *ds, int port,
reg = core_readl(priv, CORE_PORT_VLAN_CTL_PORT(port));
reg &= ~PORT_VLAN_CTRL_MASK;
reg |= (1 << port);
reg |= priv->port_sts[port].vlan_ctl_mask;
reg |= priv->dev->ports[port].vlan_ctl_mask;
core_writel(priv, reg, CORE_PORT_VLAN_CTL_PORT(port));

bcm_sf2_imp_vlan_setup(ds, cpu_port);
Expand Down
2 changes: 0 additions & 2 deletions drivers/net/dsa/bcm_sf2.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ struct bcm_sf2_port_status {
unsigned int link;

struct ethtool_eee eee;

u16 vlan_ctl_mask;
};

struct bcm_sf2_priv {
Expand Down

0 comments on commit 0215492

Please sign in to comment.