Skip to content

Commit

Permalink
mfd: wl1273-core: Use devm_mfd_add_devices() for mfd_device registration
Browse files Browse the repository at this point in the history
Use devm_mfd_add_devices() for MFD devices registration and get
rid of .remove callback to remove MFD child-devices. This is done
by managed device framework.

Signed-off-by: Laxman Dewangan <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
ldewangan authored and Lee Jones committed May 9, 2016
1 parent 6167c5b commit 14856f7
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions drivers/mfd/wl1273-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,6 @@ static int wl1273_fm_set_volume(struct wl1273_core *core, unsigned int volume)
return 0;
}

static int wl1273_core_remove(struct i2c_client *client)
{
dev_dbg(&client->dev, "%s\n", __func__);

mfd_remove_devices(&client->dev);

return 0;
}

static int wl1273_core_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
Expand Down Expand Up @@ -237,8 +228,8 @@ static int wl1273_core_probe(struct i2c_client *client,
dev_dbg(&client->dev, "%s: number of children: %d.\n",
__func__, children);

r = mfd_add_devices(&client->dev, -1, core->cells,
children, NULL, 0, NULL);
r = devm_mfd_add_devices(&client->dev, -1, core->cells,
children, NULL, 0, NULL);
if (r)
goto err;

Expand All @@ -258,7 +249,6 @@ static struct i2c_driver wl1273_core_driver = {
},
.probe = wl1273_core_probe,
.id_table = wl1273_driver_id_table,
.remove = wl1273_core_remove,
};

static int __init wl1273_core_init(void)
Expand Down

0 comments on commit 14856f7

Please sign in to comment.