Skip to content

Commit

Permalink
ALSA: maestro3: Fix Allegro mute until master volume/mute is touched
Browse files Browse the repository at this point in the history
ESS Allegro (marked ES1989S), [125d:1988] (rev 10) is mute after
loading snd-maestro3 and running alsactl restore. Touching master
volume or mute makes it work.

Looks like a bug in the AC'97 codec integrated into the chip.

Write AC97_MASTER register twice to work-around the problem.

Signed-off-by: Ondrej Zary <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
Ondrej Zary authored and tiwai committed Nov 2, 2015
1 parent 030270b commit 2c8d089
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions sound/pci/maestro3.c
Original file line number Diff line number Diff line change
Expand Up @@ -1929,6 +1929,16 @@ snd_m3_ac97_write(struct snd_ac97 *ac97, unsigned short reg, unsigned short val)
return;
snd_m3_outw(chip, val, CODEC_DATA);
snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND);
/*
* Workaround for buggy ES1988 integrated AC'97 codec. It remains silent
* until the MASTER volume or mute is touched (alsactl restore does not
* work).
*/
if (ac97->id == 0x45838308 && reg == AC97_MASTER) {
snd_m3_ac97_wait(chip);
snd_m3_outw(chip, val, CODEC_DATA);
snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND);
}
}


Expand Down

0 comments on commit 2c8d089

Please sign in to comment.