net: sched: cls_basic: fix error path in basic_change()

Signed-off-by: Jiri Pirko <[email protected]> Reviewed-by: John Fastabend <[email protected]> Signed-off-by: David S. Miller <[email protected]>
jledet · Dec 9, 2014 · bd42b78 · bd42b78
1 parent 0f6538c
commit bd42b78
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
@@ -178,10 +178,9 @@ static int basic_change(struct net *net, struct sk_buff *in_skb,
 			return -EINVAL;
 	}
 
-	err = -ENOBUFS;
 	fnew = kzalloc(sizeof(*fnew), GFP_KERNEL);
-	if (fnew == NULL)
-		goto errout;
+	if (!fnew)
+		return -ENOBUFS;
 
 	tcf_exts_init(&fnew->exts, TCA_BASIC_ACT, TCA_BASIC_POLICE);
 	err = -EINVAL;