ext4 crypto: policies may only be set on directories

Thanks to Chao Yu <[email protected]> for pointing out we were missing this check. Signed-off-by: Theodore Ts'o <[email protected]>
jljusten · May 31, 2015 · d87f6d7 · d87f6d7
1 parent c2facca
commit d87f6d7
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/fs/ext4/crypto_policy.c b/fs/ext4/crypto_policy.c
@@ -93,6 +93,8 @@ int ext4_process_policy(const struct ext4_encryption_policy *policy,
 		return -EINVAL;
 
 	if (!ext4_inode_has_encryption_context(inode)) {
+		if (!S_ISDIR(inode->i_mode))
+			return -EINVAL;
 		if (!ext4_empty_dir(inode))
 			return -ENOTEMPTY;
 		return ext4_create_encryption_context_from_policy(inode,